samples: add presubmit lint check

yoshi-automation · web-flow · commit 62de31446d7f · 2020-08-20T15:46:51.000-07:00
* changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore(java_templates): add lint/static analysis presubmit checks for samples * chore(java_templates): add lint/static analysis presubmit checks for samples * chore: fix trailing whitespace Source-Author: Jeff Ching <chingor@google.com> Source-Date: Mon Aug 17 14:29:16 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: c3caf0704f25a0c365f1c315e804a30b87c62a75 Source-Link: googleapis/synthtool@c3caf07 * chore(java_templates): stop running pmd/spotbugs checks for samples This was creating too much noise. We will revisit with other options and/or tune these checks. Source-Author: Jeff Ching <chingor@google.com> Source-Date: Wed Aug 19 12:26:49 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 9602086c6c5b05db77950c7f7495a2a3868f3537 Source-Link: googleapis/synthtool@9602086
diff --git a/.github/workflows/samples.yaml b/.github/workflows/samples.yaml
@@ -0,0 +1,14 @@
+on:
+  pull_request:
+name: samples
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-java@v1
+        with:
+          java-version: 8
+      - name: Run checkstyle
+        run: mvn -P lint --quiet --batch-mode checkstyle:check
+        working-directory: samples/snippets
diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file
     <dependency>
       <groupId>com.google.cloud</groupId>
       <artifactId>libraries-bom</artifactId>
-      <version>9.0.0</version>
+      <version>9.1.0</version>
       <type>pom</type>
       <scope>import</scope>
     </dependency>
diff --git a/synth.metadata b/synth.metadata
@@ -4,7 +4,7 @@
       "git": {
         "name": ".",
         "remote": "https://github.com/googleapis/java-errorreporting.git",
-        "sha": "eb2af63754790a8c3ecaa9d4c55412428c6716df"
+        "sha": "da64e84f721d0c3ed648dc6e4a4294a83e398fed"
       }
     },
     {
@@ -19,7 +19,7 @@
       "git": {
         "name": "synthtool",
         "remote": "https://github.com/googleapis/synthtool.git",
-        "sha": "f8823dec98277a9516f2fb6fae9f58b3a59a23e1"
+        "sha": "9602086c6c5b05db77950c7f7495a2a3868f3537"
       }
     }
   ],
@@ -43,6 +43,7 @@
     ".github/release-please.yml",
     ".github/trusted-contribution.yml",
     ".github/workflows/ci.yaml",
+    ".github/workflows/samples.yaml",
     ".kokoro/build.bat",
     ".kokoro/build.sh",
     ".kokoro/coerce_logs.sh",

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`"git": {`
`5`	`5`	`"name": ".",`
`6`	`6`	`"remote": "https://github.com/googleapis/java-errorreporting.git",`
`7`		`- "sha": "eb2af63754790a8c3ecaa9d4c55412428c6716df"`
	`7`	`+ "sha": "da64e84f721d0c3ed648dc6e4a4294a83e398fed"`
`8`	`8`	`}`
`9`	`9`	`},`
`10`	`10`	`{`
`@@ -19,7 +19,7 @@`
`19`	`19`	`"git": {`
`20`	`20`	`"name": "synthtool",`
`21`	`21`	`"remote": "https://github.com/googleapis/synthtool.git",`
`22`		`- "sha": "f8823dec98277a9516f2fb6fae9f58b3a59a23e1"`
	`22`	`+ "sha": "9602086c6c5b05db77950c7f7495a2a3868f3537"`
`23`	`23`	`}`
`24`	`24`	`}`
`25`	`25`	`],`
`@@ -43,6 +43,7 @@`
`43`	`43`	`".github/release-please.yml",`
`44`	`44`	`".github/trusted-contribution.yml",`
`45`	`45`	`".github/workflows/ci.yaml",`
	`46`	`+ ".github/workflows/samples.yaml",`
`46`	`47`	`".kokoro/build.bat",`
`47`	`48`	`".kokoro/build.sh",`
`48`	`49`	`".kokoro/coerce_logs.sh",`