Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

samples: add lifecycle config to cluster creation#858

Closed
anguillanneuf wants to merge 2 commits into
mainfrom
anguillanneuf-patch-1
Closed

samples: add lifecycle config to cluster creation#858
anguillanneuf wants to merge 2 commits into
mainfrom
anguillanneuf-patch-1

Conversation

@anguillanneuf

@anguillanneuf anguillanneuf commented May 23, 2022 •
edited
Loading

Copy link
Copy Markdown

When tests fail, the cleanup steps don't run, resulting in leaked resources.

Add lifecycle config during cluster creation to make sure unused clusters get deleted.

May need to wait for both #838 and #859

@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: dataproc Issues related to the googleapis/java-dataproc API. samples Issues that are directly related to samples. labels May 23, 2022
@meredithslota meredithslota requested a review from lesv June 21, 2022 23:04
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@alicejli alicejli added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 12, 2022
@alicejli

alicejli commented Jul 12, 2022

Copy link
Copy Markdown
Contributor

@anguillanneuf Seems like there's a compilation error:

[ERROR] /tmpfs/src/github/java-dataproc/samples/snippets/src/main/java/CreateCluster.java:[78,14] error: cannot find symbol
  symbol:   method setLifecycleConfig(LifecycleConfig)
  location: class Builder

lesv
lesv approved these changes Apr 26, 2023
View reviewed changes

@lesv lesv left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify this is still required @anguillanneuf as it's very old. In the future, feel free to ping me on these.

@anguillanneuf

anguillanneuf commented Apr 26, 2023

Copy link
Copy Markdown
Author

It looks like #997 removed samples. this is no longer needed.

@anguillanneuf anguillanneuf deleted the anguillanneuf-patch-1 branch April 26, 2023 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lesv lesv lesv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lesv lesv

Labels

api: dataproc Issues related to the googleapis/java-dataproc API. samples Issues that are directly related to samples. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anguillanneuf @alicejli @lesv @yoshi-kokoro