Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Change default var for network#762

Merged
gcf-merge-on-green[bot] merged 1 commit into
mainfrom
issue-ci-it-tests
Jul 28, 2022
Merged

Change default var for network#762
gcf-merge-on-green[bot] merged 1 commit into
mainfrom
issue-ci-it-tests

Conversation

@xtineskim

@xtineskim xtineskim commented Jul 20, 2022

Copy link
Copy Markdown
Contributor

Fixes #n/a☕️
Changed the network name being created
We were seeing the error where we ran into too many clusters being created with the default vpc network, which was also being by other java CI flows not in this repo.

@xtineskim xtineskim requested a review from a team July 20, 2022 18:59
@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Jul 20, 2022

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: container Issues related to the googleapis/java-container API. labels Jul 20, 2022
@xtineskim xtineskim added the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2022
@gcf-merge-on-green

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 22, 2022
@xtineskim xtineskim changed the title [not ready for review]Change default var for network Change default var for network Jul 26, 2022
@xtineskim xtineskim force-pushed the issue-ci-it-tests branch from 40cab33 to 06102fb Compare July 26, 2022 13:34
@xtineskim xtineskim requested review from a team, Shabirmean and lqiu96 July 26, 2022 14:26

@Shabirmean Shabirmean left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lqiu96 lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@lqiu96 lqiu96 added the automerge Merge the pull request once unit tests and other checks pass. label Jul 28, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 5bd32ac into main Jul 28, 2022
@gcf-merge-on-green gcf-merge-on-green Bot deleted the issue-ci-it-tests branch July 28, 2022 20:18
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: container Issues related to the googleapis/java-container API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants