Skip to content
This repository was archived by the owner on Jan 22, 2024. It is now read-only.

deps(sample): using newer google-analytics-data in snippet#452

Merged
gcf-merge-on-green[bot] merged 3 commits into
googleapis:mainfrom
suztomo:use_newer_google-analytics-data
Mar 21, 2022
Merged

deps(sample): using newer google-analytics-data in snippet#452
gcf-merge-on-green[bot] merged 3 commits into
googleapis:mainfrom
suztomo:use_newer_google-analytics-data

Conversation

@suztomo

@suztomo suztomo commented Mar 21, 2022

Copy link
Copy Markdown
Member

Fixes #430 and #431 .

@suztomo suztomo requested review from a team March 21, 2022 19:15
@product-auto-label product-auto-label Bot added the api: analyticsdata Issues related to the googleapis/java-analytics-data API. label Mar 21, 2022
@generated-files-bot

generated-files-bot Bot commented Mar 21, 2022

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

  • .kokoro/build.sh
  • samples/install-without-bom/pom.xml
  • samples/snippets/pom.xml

@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Mar 21, 2022
@suztomo

suztomo commented Mar 21, 2022

Copy link
Copy Markdown
Member Author

Downgrading 0.11.6 succeeded for all the tests, including the ones for nightly builds.

image

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 21, 2022
Comment thread .kokoro/build.sh
SAMPLES_DIR=samples
# only run ITs in snapshot/ on presubmit PRs. run ITs in all 3 samples/ subdirectories otherwise.
if [[ ! -z ${KOKORO_GITHUB_PULL_REQUEST_NUMBER} ]]
then
SAMPLES_DIR=samples/snapshot
fi

@suztomo suztomo Mar 21, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed these lines to run all tests in samples directory. Owlbot will revert this change. But it's ok. I just want to confirm the latest version of the library works with the latest auth library.

@suztomo suztomo added the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2022
@gcf-merge-on-green gcf-merge-on-green Bot merged commit 74446cf into googleapis:main Mar 21, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 21, 2022
gcf-merge-on-green Bot pushed a commit that referenced this pull request Mar 21, 2022
🤖 I have created a release *beep* *boop*
---


### [0.11.7](v0.11.6...v0.11.7) (2022-03-21)


### Dependencies

* **sample:** using newer google-analytics-data in snippet ([#452](#452)) ([74446cf](74446cf))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@suztomo suztomo deleted the use_newer_google-analytics-data branch March 21, 2022 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: analyticsdata Issues related to the googleapis/java-analytics-data API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

com.example.analytics.QuickstartSampleTest: testQuickstart failed

3 participants