Skip to content

Vision: Add more product categories (via synth). #9224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 1 commit into from
Sep 13, 2019
Merged

Vision: Add more product categories (via synth). #9224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions vision/google/cloud/vision_v1/proto/product_search.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ message ProductSearchParams {
string product_set = 6;

// The list of product categories to search in. Currently, we only consider
// the first category, and either "homegoods-v2", "apparel-v2", or "toys-v2"
// should be specified. The legacy categories "homegoods", "apparel", and
// "toys" are still supported but will be deprecated. For new products, please
// use "homegoods-v2", "apparel-v2", or "toys-v2" for better product search
// accuracy. It is recommended to migrate existing products to these
// categories as well.
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2",
// "packagedgoods-v1", or "general-v1" should be specified. The legacy
// categories "homegoods", "apparel", and "toys" are still supported but will
// be deprecated. For new products, please use "homegoods-v2", "apparel-v2",
// or "toys-v2" for better product search accuracy. It is recommended to
// migrate existing products to these categories as well.
repeated string product_categories = 7;

// The filtering expression. This can be used to restrict search results based
Expand Down
13 changes: 7 additions & 6 deletions vision/google/cloud/vision_v1/proto/product_search_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions vision/google/cloud/vision_v1/proto/product_search_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,9 @@ message Product {
string description = 3;

// The category for the product identified by the reference image. This should
// be either "homegoods-v2", "apparel-v2", or "toys-v2". The legacy categories
// "homegoods", "apparel", and "toys" are still supported, but these should
// not be used for new products.
// be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or
// "general-v1" The legacy categories "homegoods", "apparel", and "toys" are
// still supported, but these should not be used for new products.
//
// This field is immutable.
string product_category = 4;
Expand Down
9 changes: 5 additions & 4 deletions vision/google/cloud/vision_v1/proto/product_search_service_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions vision/google/cloud/vision_v1p4beta1/proto/product_search.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ message ProductSearchParams {
string product_set = 6;

// The list of product categories to search in. Currently, we only consider
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2", or
// "packagedgoods-v1" should be specified. The legacy categories "homegoods",
// "apparel", and "toys" are still supported but will be deprecated. For new
// products, please use "homegoods-v2", "apparel-v2", or "toys-v2" for better
// product search accuracy. It is recommended to migrate existing products to
// these categories as well.
// the first category, and either "homegoods-v2", "apparel-v2", "toys-v2",
// "packagedgoods-v1", or "general-v1" should be specified. The legacy
// categories "homegoods", "apparel", and "toys" are still supported but will
// be deprecated. For new products, please use "homegoods-v2", "apparel-v2",
// or "toys-v2" for better product search accuracy. It is recommended to
// migrate existing products to these categories as well.
repeated string product_categories = 7;

// The filtering expression. This can be used to restrict search results based
Expand Down
14 changes: 7 additions & 7 deletions vision/google/cloud/vision_v1p4beta1/proto/product_search_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions vision/google/cloud/vision_v1p4beta1/proto/product_search_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,12 +355,9 @@ message Product {
string description = 3;

// The category for the product identified by the reference image. This should
// be either "homegoods-v2", "apparel-v2", "toys-v2", or "packagedgoods-v1".
// The legacy categories "homegoods", "apparel", and "toys" are still
// supported but will be deprecated. For new products, please use
// "homegoods-v2", "apparel-v2", or "toys-v2" for better product search
// accuracy. It is recommended to migrate existing products to these
// categories as well.
// be either "homegoods-v2", "apparel-v2", "toys-v2", "packagedgoods-v1", or
// "general-v1" The legacy categories "homegoods", "apparel", and "toys" are
// still supported, but these should not be used for new products.
//
// This field is immutable.
string product_category = 4;
Expand Down
11 changes: 4 additions & 7 deletions vision/google/cloud/vision_v1p4beta1/proto/product_search_service_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions vision/synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-08-16T12:45:12.445594Z",
"updateTime": "2019-09-13T12:40:57.067863Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.33.0",
"dockerImage": "googleapis/artman@sha256:c6231efb525569736226b1f7af7565dbc84248efafb3692a5bb1d2d8a7975d53"
"version": "0.36.2",
"dockerImage": "googleapis/artman@sha256:0e6f3a668cd68afc768ecbe08817cf6e56a0e64fcbdb1c58c3b97492d12418a1"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "2a02e33c79cbf23d316c57e1c78f915e1d905eee",
"internalRef": "263682410"
"sha": "dc88acb2ced136067d3ed2356b6a87ca7f017a96",
"internalRef": "268735517"
}
},
{
Expand Down