BigQuery: Treat NaN as NULL when converting from pandas to arrow.#8785
Merged
tswast merged 2 commits intogoogleapis:masterfrom Jul 25, 2019
Merged
BigQuery: Treat NaN as NULL when converting from pandas to arrow.#8785tswast merged 2 commits intogoogleapis:masterfrom
tswast merged 2 commits intogoogleapis:masterfrom
Conversation
Fixes broken unit tests from latest pyarrow release.
googlebot
added
the
cla: yes
tswast
changed the title
tswast
added
api: bigquery
tseaver
approved these changes
Jul 25, 2019
Contributor
|
Do we need a minimum version of PyArrow to account for the new behavior? |
plamut
approved these changes
Jul 25, 2019
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
Based on the info from the link, the change looks good.
Contributor
Author
The new behavior is present in 0.14.0 and later. I don't really have a strong opinion one way or the other on how NaN values are handled, so I'm hesitant to restrict the pyarrow version in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken unit tests from latest pyarrow release.