BigQuery: Use configurable bucket name for GCS samples data in systems tests.#8783
Merged
tswast merged 3 commits intogoogleapis:masterfrom Jul 29, 2019
Merged
Conversation
This allows the VPC-SC team to use their private mirror which is within the security boundary when testing BigQuery VPC-SC support.
tseaver
reviewed
Jul 25, 2019
| # The VPC-SC team maintains a mirror of the GCS bucket used for code | ||
| # samples. The public bucket crosses the configured security boundary. | ||
| # See: https://github.com/googleapis/google-cloud-python/issues/8550 | ||
| SAMPLES_BUCKET = os.environ.get("GCLOUD_TEST_SAMPLES_BUCKET", "cloud-samples-data") |
Contributor
There was a problem hiding this comment.
Do we need to update noxfile.py to set this value in the environment?
Contributor
Author
There was a problem hiding this comment.
No, the default of cloud-samples-data is fine for our purposes. The VPC-SC team has a separate Kokoro (or maybe something similar?) config where they'll set the necessary environment variable.
Contributor
Author
failure is unrelated. I think it's a behavior change / regression from |
Contributor
|
@tswast How should we track that regression? All BigQuery CI is b0rked ATM. |
Contributor
Author
Let's pin to |
Contributor
Author
|
Sent #8784. |
shollyman
approved these changes
Jul 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the VPC-SC team to use their private mirror which is within
the security boundary when testing BigQuery VPC-SC support.
Closes #8550.