BigQuery: Add sample demontrating how to create a job.#8422
Merged
tswast merged 3 commits intogoogleapis:masterfrom Jun 19, 2019
Merged
BigQuery: Add sample demontrating how to create a job.#8422tswast merged 3 commits intogoogleapis:masterfrom
tswast merged 3 commits intogoogleapis:masterfrom
Conversation
This sample is intended for https://cloud.google.com/bigquery/docs/running-jobs It demonstrates advanced features, such as overriding location autodetection and overriding job ID generation.
tswast
added
api: bigquery
googlebot
added
the
cla: yes
Contributor
|
I think it makes more sense to have the documentation about the location in the docs, rather than copied into a comment in each language's snippet. I also don't think it's a good idea to put URLs in comments. It can become a problem if pages are moved or if this sample ends up being included on the page it's linking to. |
tseaver
changed the title
tseaver
approved these changes
Jun 19, 2019
Contributor
Author
|
Removed the link and the comment about location autodetection. I'll make sure that is documented when I add the sample to the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sample is intended for https://cloud.google.com/bigquery/docs/running-jobs
It demonstrates advanced features, such as overriding location
autodetection and overriding job ID generation.
cc @grant @shollyman @alixhami