Vision: Add negative Vision API Product Search tests for VPC SC#8269
Merged
busunkim96 merged 1 commit intogoogleapis:masterfrom Jun 10, 2019
Merged
Vision: Add negative Vision API Product Search tests for VPC SC#8269busunkim96 merged 1 commit intogoogleapis:masterfrom
busunkim96 merged 1 commit intogoogleapis:masterfrom
Conversation
…d by VPC SC when trying to access a resource outside of a secure perimeter when run from within a secure perimeter.
googlebot
added
the
cla: yes
busunkim96
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
busunkim96
reviewed
Jun 10, 2019
| LOGO_FILE = os.path.join(_SYS_TESTS_DIR, "data", "logo.png") | ||
| PDF_FILE = os.path.join(_SYS_TESTS_DIR, "data", "pdf_test.pdf") | ||
| PROJECT_ID = os.environ.get("PROJECT_ID") | ||
| PROJECT_OUTSIDE = os.environ.get("GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT") |
Contributor
There was a problem hiding this comment.
Should we be setting this environment variable in our tests environment? Or are these tests being run somewhere else?
Contributor
Author
There was a problem hiding this comment.
The VPC SC test is being run elsewhere. No need for you to set this environment variable.
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
…d by VPC SC when trying to access a resource outside of a secure perimeter when run from within a secure perimeter. (#8269)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verifies ProductSearch is blocked by VPC SC when trying to access a resource outside of a secure perimeter when run from within a secure perimeter.