Skip to content

Conversation

@johangp
Copy link
Contributor

@johangp johangp commented Feb 2, 2019

I changed some of the documentation of some methods like table.read_rows() because the parameter row_set in type is ok, but not in param. It was a little confuse to me.

I changed some of the documentation of some methods like table.read_rows() because the parameter row_set in type is ok, but not in param. It was a little confuse to me.
@johangp johangp requested a review from crwilcox as a code owner February 2, 2019 02:45
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 2, 2019
@johangp
Copy link
Contributor Author

johangp commented Feb 2, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 2, 2019
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

@tseaver tseaver merged commit 850785b into googleapis:master Feb 4, 2019
@johangp johangp deleted the patch-1 branch February 4, 2019 21:18
parthea pushed a commit that referenced this pull request Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants