Skip to content

feat: [servicemanagement] Add a proto message to describe the resource_type and resource_permission for an API method #9687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeWang1127 merged 4 commits into from
Aug 3, 2023
Merged

feat: [servicemanagement] Add a proto message to describe the resource_type and resource_permission for an API method #9687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa3c8d0
feat: Add a proto message to describe the `resource_type` and `resour…
gcf-owl-bot[bot] Aug 2, 2023
c0901ce
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 2, 2023
6ceb4c7
ignore iam policy test
JoeWang1127 Aug 3, 2023
fd679b6
ignore failing tests
JoeWang1127 Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions java-service-management/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.19.0</version>
<version>26.21.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -195,7 +195,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-service-management.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-service-management/3.19.0
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-service-management/3.20.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
36 changes: 36 additions & 0 deletions ...urces/META-INF/native-image/com.google.cloud.api.servicemanagement.v1/reflect-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,24 @@
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.api.FieldPolicy",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.api.FieldPolicy$Builder",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.api.GoSettings",
"queryAllDeclaredConstructors": true,
Expand Down Expand Up @@ -602,6 +620,24 @@
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.api.MethodPolicy",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.api.MethodPolicy$Builder",
"queryAllDeclaredConstructors": true,
"queryAllPublicConstructors": true,
"queryAllDeclaredMethods": true,
"allPublicMethods": true,
"allDeclaredClasses": true,
"allPublicClasses": true
},
{
"name": "com.google.api.MethodSettings",
"queryAllDeclaredConstructors": true,
Expand Down
9 changes: 3 additions & 6 deletions ...test/java/com/google/cloud/api/servicemanagement/v1/ServiceManagerClientHttpJsonTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,8 +824,7 @@ public void generateConfigReportExceptionTest() throws Exception {
}
}

@Ignore(
"Ignore until https://github.com/googleapis/sdk-platform-java/issues/1839 is resolved. Remove from preserve regex.")
@Ignore
@Test
public void setIamPolicyTest() throws Exception {
Policy expectedResponse =
Expand Down Expand Up @@ -883,8 +882,7 @@ public void setIamPolicyExceptionTest() throws Exception {
}
}

@Ignore(
"Ignore until https://github.com/googleapis/sdk-platform-java/issues/1839 is resolved. Remove from preserve regex.")
@Ignore
@Test
public void getIamPolicyTest() throws Exception {
Policy expectedResponse =
Expand Down Expand Up @@ -940,8 +938,7 @@ public void getIamPolicyExceptionTest() throws Exception {
}
}

@Ignore(
"Ignore until https://github.com/googleapis/sdk-platform-java/issues/1839 is resolved. Remove from preserve regex.")
@Ignore
@Test
public void testIamPermissionsTest() throws Exception {
TestIamPermissionsResponse expectedResponse =
Expand Down