Skip to content

Refactoring Publisher.publishOutstandingBatch#4977

Merged
sduskis merged 2 commits into
googleapis:masterfrom
sduskis:generics_publisher
Apr 18, 2019
Merged

Refactoring Publisher.publishOutstandingBatch#4977
sduskis merged 2 commits into
googleapis:masterfrom
sduskis:generics_publisher

Conversation

@sduskis

@sduskis sduskis commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

This will make the class look more like the ordering keys changes

This will make the class look more like the ordering keys changes
@sduskis sduskis requested a review from a team April 18, 2019 11:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 18, 2019
@codecov

codecov Bot commented Apr 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4977 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4977   +/-   ##
=========================================
  Coverage     50.32%   50.32%           
- Complexity    23665    23666    +1     
=========================================
  Files          2238     2238           
  Lines        226045   226045           
  Branches      24957    24957           
=========================================
  Hits         113751   113751           
  Misses       103697   103697           
  Partials       8597     8597
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/pubsub/v1/Publisher.java 82.47% <100%> (ø) 27 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 909d094...c402107. Read the comment docs.

@olavloite olavloite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduskis sduskis merged commit 8894854 into googleapis:master Apr 18, 2019
@sduskis sduskis deleted the generics_publisher branch April 22, 2019 22:16
meltsufin pushed a commit that referenced this pull request Apr 29, 2026
* Refactoring Publisher.publishOutstandingBatch
This will make the class look more like the ordering keys changes

* Ran the formatter
meltsufin pushed a commit that referenced this pull request May 1, 2026
* Refactoring Publisher.publishOutstandingBatch
This will make the class look more like the ordering keys changes

* Ran the formatter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants