Skip to content

Bigquery: Fix bug for ProjectId in listTableData.#4965

Merged
sduskis merged 1 commit into
googleapis:masterfrom
pmakani:api-bigquery-bug-4934
Apr 25, 2019
Merged

Bigquery: Fix bug for ProjectId in listTableData.#4965
sduskis merged 1 commit into
googleapis:masterfrom
pmakani:api-bigquery-bug-4934

Conversation

@pmakani

@pmakani pmakani commented Apr 17, 2019

Copy link
Copy Markdown

Fixes #4934

@pmakani pmakani requested a review from a team April 17, 2019 12:44
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2019
@codecov

codecov Bot commented Apr 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #4965 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4965      +/-   ##
============================================
- Coverage     50.36%   50.36%   -0.01%     
  Complexity    23666    23666              
============================================
  Files          2232     2232              
  Lines        225859   225859              
  Branches      24956    24956              
============================================
- Hits         113753   113752       -1     
- Misses       103510   103511       +1     
  Partials       8596     8596
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 84.09% <100%> (+0.25%) 53 <0> (+1) ⬆️
...able/gaxx/reframing/ReframingResponseObserver.java 88.99% <0%> (-1.84%) 29% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10070bd...d57f375. Read the comment docs.

@sduskis sduskis requested a review from shollyman April 17, 2019 15:35
@sduskis

sduskis commented Apr 17, 2019

Copy link
Copy Markdown
Contributor

@shollyman, this looks good to me. What do you think?

@yoshi-automation yoshi-automation added the 🚨 critical P0 critical issue. Requires immediate fix label Apr 24, 2019
@sduskis

sduskis commented Apr 25, 2019

Copy link
Copy Markdown
Contributor

@shollyman, ping

@shollyman shollyman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@sduskis sduskis merged commit 264643d into googleapis:master Apr 25, 2019
@pmakani pmakani deleted the api-bigquery-bug-4934 branch April 29, 2019 06:24
@JesseLovelace JesseLovelace mentioned this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 critical P0 critical issue. Requires immediate fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

com.google.cloud.bigquery.Job.getQueryResults fails on job that writes to destination table in different project

5 participants