Skip to content

Commit b18e396

Browse files
athakorchingor13
athakor
authored and
chingor13
committed
Cleanup unused dependencies in google-cloud-contrib (#5616)
* cleanup unused dependency of contrib-google-cloud-logging-logback * cleanup unused dependency of contrib-google-cloud-nio-examples * cleanup unused dependency of contrib-google-cloud-notification * cleanup unused dependency of contrib-google-cloud-logging-logback * cleanup unused dependency of contrib-google-cloud-nio * cleanup unused dependency of contrib-google-cloud-notification
1 parent 9062789 commit b18e396

4 files changed

Lines changed: 7 additions & 70 deletions

File tree

  • google-cloud-clients/google-cloud-contrib

‎google-cloud-clients/google-cloud-contrib/google-cloud-logging-logback/pom.xml‎

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<project xmlns="http://maven.apache.org/POM/4.0.0"
3-
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4-
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
66

77
<artifactId>google-cloud-logging-logback</artifactId>
@@ -38,21 +38,10 @@
3838
<artifactId>easymock</artifactId>
3939
<scope>test</scope>
4040
</dependency>
41-
<dependency>
42-
<groupId>org.objenesis</groupId>
43-
<artifactId>objenesis</artifactId>
44-
<scope>test</scope>
45-
</dependency>
46-
<dependency>
47-
<groupId>junit</groupId>
48-
<artifactId>junit</artifactId>
49-
<version>4.12</version>
50-
<scope>test</scope>
51-
</dependency>
5241
<dependency>
5342
<groupId>com.google.truth</groupId>
5443
<artifactId>truth</artifactId>
5544
<scope>test</scope>
5645
</dependency>
5746
</dependencies>
58-
</project>
47+
</project>

‎google-cloud-clients/google-cloud-contrib/google-cloud-nio-examples/pom.xml‎

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@
1717
<properties>
1818
<site.installationModule>google-cloud-nio-examples</site.installationModule>
1919
</properties>
20-
<dependencies>
21-
<dependency>
22-
<groupId>${project.groupId}</groupId>
23-
<artifactId>google-cloud-storage</artifactId>
24-
</dependency>
25-
</dependencies>
2620
<build>
2721
<plugins>
2822
<plugin>
@@ -34,4 +28,4 @@
3428
</plugin>
3529
</plugins>
3630
</build>
37-
</project>
31+
</project>

‎google-cloud-clients/google-cloud-contrib/google-cloud-nio/pom.xml‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,6 @@
2222
<groupId>${project.groupId}</groupId>
2323
<artifactId>google-cloud-storage</artifactId>
2424
</dependency>
25-
<dependency>
26-
<groupId>com.google.guava</groupId>
27-
<artifactId>guava</artifactId>
28-
</dependency>
29-
<dependency>
30-
<groupId>com.google.code.findbugs</groupId>
31-
<artifactId>jsr305</artifactId>
32-
</dependency>
3325
<dependency>
3426
<groupId>javax.inject</groupId>
3527
<artifactId>javax.inject</artifactId>

‎google-cloud-clients/google-cloud-contrib/google-cloud-notification/pom.xml‎

Lines changed: 3 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0"?>
22
<project xmlns="http://maven.apache.org/POM/4.0.0"
3-
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4-
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
3+
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
4+
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
55
<modelVersion>4.0.0</modelVersion>
66
<artifactId>google-cloud-notification</artifactId>
77
<version>0.98.1-beta-SNAPSHOT</version><!-- {x-version-update:google-cloud-notification:current} -->
@@ -21,10 +21,6 @@
2121
<site.installationModule>google-cloud-notification</site.installationModule>
2222
</properties>
2323
<dependencies>
24-
<dependency>
25-
<groupId>${project.groupId}</groupId>
26-
<artifactId>google-cloud-core</artifactId>
27-
</dependency>
2824
<dependency>
2925
<groupId>${project.groupId}</groupId>
3026
<artifactId>google-cloud-storage</artifactId>
@@ -33,50 +29,16 @@
3329
<groupId>${project.groupId}</groupId>
3430
<artifactId>google-cloud-pubsub</artifactId>
3531
</dependency>
36-
<dependency>
37-
<groupId>${project.groupId}</groupId>
38-
<artifactId>google-cloud-core-grpc</artifactId>
39-
</dependency>
40-
<dependency>
41-
<groupId>com.google.api</groupId>
42-
<artifactId>gax-grpc</artifactId>
43-
</dependency>
44-
<dependency>
45-
<groupId>com.google.api</groupId>
46-
<artifactId>api-common</artifactId>
47-
</dependency>
4832
<dependency>
4933
<groupId>com.google.api.grpc</groupId>
5034
<artifactId>proto-google-cloud-pubsub-v1</artifactId>
5135
</dependency>
52-
<dependency>
53-
<groupId>com.google.api.grpc</groupId>
54-
<artifactId>grpc-google-cloud-pubsub-v1</artifactId>
55-
<scope>test</scope>
56-
</dependency>
57-
<dependency>
58-
<groupId>io.grpc</groupId>
59-
<artifactId>grpc-netty-shaded</artifactId>
60-
</dependency>
61-
<dependency>
62-
<groupId>io.grpc</groupId>
63-
<artifactId>grpc-stub</artifactId>
64-
</dependency>
65-
<dependency>
66-
<groupId>io.grpc</groupId>
67-
<artifactId>grpc-auth</artifactId>
68-
</dependency>
6936

7037
<!-- Test dependencies -->
7138
<dependency>
7239
<groupId>junit</groupId>
7340
<artifactId>junit</artifactId>
7441
<scope>test</scope>
7542
</dependency>
76-
<dependency>
77-
<groupId>org.mockito</groupId>
78-
<artifactId>mockito-all</artifactId>
79-
<scope>test</scope>
80-
</dependency>
8143
</dependencies>
82-
</project>
44+
</project>

0 commit comments

Comments
 (0)