fix(storage): copy metadata when using Copier with grpc#12919
Merged
BrennaEpp merged 3 commits intogoogleapis:mainfrom Oct 14, 2025
Merged
fix(storage): copy metadata when using Copier with grpc#12919BrennaEpp merged 3 commits intogoogleapis:mainfrom
BrennaEpp merged 3 commits intogoogleapis:mainfrom
Conversation
We need to not set `destination` on the request unless the user specifies attrs. Since the struct is not a pointer, we have to check if it is empty to determine if it has not been set.
product-auto-label
bot
added
the
api: storage
tritone
reviewed
Sep 19, 2025
Contributor
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
Looks like a good approach but Copier retry tests seem to be failing now in the CI. Can you look into this?
BrennaEpp
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
tritone
previously approved these changes
Oct 7, 2025
Contributor
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
Nice approach, thanks for the changes.
tritone
approved these changes
Oct 14, 2025
krishnamd-jkp
pushed a commit
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.57.1](storage/v1.57.0...storage/v1.57.1) (2025-10-28) ### Bug Fixes * **storage:** Takeover idempotence. ([#13230](#13230)) ([cc5d2a1](cc5d2a1)) * **storage:** Copy metadata when using Copier with grpc ([#12919](#12919)) ([57a2e80](57a2e80)) * **storage:** Fix takeover response handling. ([#13239](#13239)) ([26d75bc](26d75bc)) * **storage:** Remove default timeout for gRPC operations ([#13022](#13022)) ([b94c3ba](b94c3ba)) * **storage:** Skip download of file outside of target dir ([#12945](#12945)) ([6259aee](6259aee)) * **storage:** Upgrade gRPC service registration func ([8fffca2](8fffca2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Brenna N Epp <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to not set
destinationon the request unless the user specifies attrs. Since the struct is not a pointer, we have to check if it is empty to determine if it has not been set.