chore: add GCS_BUCKET env var #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: This pull request is touching the following templated files:
|
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
=========================================
Coverage 83.59% 83.59%
Complexity 604 604
=========================================
Files 42 42
Lines 2712 2712
Branches 289 289
=========================================
Hits 2267 2267
Misses 303 303
Partials 142 142 Continue to review full report at Codecov.
|
Neenu1995
approved these changes
Apr 6, 2021
Neenu1995
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #618 ☕️
GCS_BUCKET env needed here but set up got removed with synthtool update here