Skip to content

chore: Pause automatic requests to MDS Universe Domain endpoint.#2871

Merged
amanda-tarafa merged 1 commit into
googleapis:mainfrom
amanda-tarafa:universe-domain-no-validation
Nov 5, 2024
Merged

chore: Pause automatic requests to MDS Universe Domain endpoint.#2871
amanda-tarafa merged 1 commit into
googleapis:mainfrom
amanda-tarafa:universe-domain-no-validation

Conversation

@amanda-tarafa

Copy link
Copy Markdown
Contributor

This applies to Discovery based libraries only. There will be an accompanying PR for GAPICs.

Towards b/371768149

This applies to Discovery based libraries only. There will be an accompanying PR for GAPICs.

Towards b/371768149
@amanda-tarafa amanda-tarafa requested review from a team and jskeet November 5, 2024 00:32
amanda-tarafa added a commit to amanda-tarafa/gax-dotnet that referenced this pull request Nov 5, 2024
This applies to GAPIC based libraries only. Discovery based libraries are handled in googleapis/google-api-dotnet-client#2871.

Towards b/371768149
jskeet pushed a commit to googleapis/gax-dotnet that referenced this pull request Nov 5, 2024
This applies to GAPIC based libraries only. Discovery based libraries are handled in googleapis/google-api-dotnet-client#2871.

Towards b/371768149
@amanda-tarafa amanda-tarafa merged commit dd89da6 into googleapis:main Nov 5, 2024
@amanda-tarafa amanda-tarafa deleted the universe-domain-no-validation branch November 5, 2024 07:41
amanda-tarafa added a commit to amanda-tarafa/google-api-dotnet-client that referenced this pull request Jan 23, 2025
Fixes:

- googleapis#2869 Use universe-domain instead of universe_domain as the MDS endpoint
- googleapis#2870 BaseClientService.UniverDomain setter is obsolete
- googleapis#2871 Pause automatic requests to MDS Universe Domain endpoint

Features:

- googleapis#2746 Simplify setting the HttpClient timeout
- googleapis#2809 Improve error handling when signing with the IAM service

  BREAKING CHANGE: The ComputeCredential and ImpersonatedCredential SignBlobAsync methods will throw a GoogleApiException instead of a HttpRequestExtension. The GoogleApiException makes the HttpResponseMessage content available, which usually includes details about the error.
  We consider the risk of this change breaking users  lower than the risk of disrupting all users with a new major version so we've decided to release this breaking change on a minor version of the library. Please create an issue on this repo if you are affected and we will e happy to help.

- googleapis#2879 Use recommended retries for token and IAM sign blob endpoints
- googleapis#2913 Support GOOGLE_CLOUD_UNIVERSE_DOMAIN environment variable

Dependencies:

- googleapis#2730 Remove unused dependency Microsoft.AspNetCore.Authorization from Google.Apis.Auth.AspNetCore3

  BREAKING CHANGE: Projects using Google.Apis.Auth.AspNetCore3 that transitively depend on Microsoft.AspNetCore.Authorization may be broken. They only need to add an implicit dependency themselves. We consider the risk of this change breaking users  lower than the risk of disrupting all users with a new major version so we've decided to release this breaking change on a minor version of the library. Please create an issue on this repo if you are affected and we will e happy to help.

Documentation:

- googleapis#2916 Add warning note about user provided credential configurations
amanda-tarafa added a commit that referenced this pull request Jan 23, 2025
Fixes:

- #2869 Use universe-domain instead of universe_domain as the MDS endpoint
- #2870 BaseClientService.UniverDomain setter is obsolete
- #2871 Pause automatic requests to MDS Universe Domain endpoint

Features:

- #2746 Simplify setting the HttpClient timeout
- #2809 Improve error handling when signing with the IAM service

  BREAKING CHANGE: The ComputeCredential and ImpersonatedCredential SignBlobAsync methods will throw a GoogleApiException instead of a HttpRequestExtension. The GoogleApiException makes the HttpResponseMessage content available, which usually includes details about the error.
  We consider the risk of this change breaking users  lower than the risk of disrupting all users with a new major version so we've decided to release this breaking change on a minor version of the library. Please create an issue on this repo if you are affected and we will e happy to help.

- #2879 Use recommended retries for token and IAM sign blob endpoints
- #2913 Support GOOGLE_CLOUD_UNIVERSE_DOMAIN environment variable

Dependencies:

- #2730 Remove unused dependency Microsoft.AspNetCore.Authorization from Google.Apis.Auth.AspNetCore3

  BREAKING CHANGE: Projects using Google.Apis.Auth.AspNetCore3 that transitively depend on Microsoft.AspNetCore.Authorization may be broken. They only need to add an implicit dependency themselves. We consider the risk of this change breaking users  lower than the risk of disrupting all users with a new major version so we've decided to release this breaking change on a minor version of the library. Please create an issue on this repo if you are affected and we will e happy to help.

Documentation:

- #2916 Add warning note about user provided credential configurations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants