Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

chore: Use Java11 for release#420

Merged
lqiu96 merged 3 commits into
mainfrom
main-use_java11
Dec 6, 2022
Merged

chore: Use Java11 for release#420
lqiu96 merged 3 commits into
mainfrom
main-use_java11

Conversation

@lqiu96

@lqiu96 lqiu96 commented Dec 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

BEGIN_COMMIT_OVERRIDE
fix: Build with JDK11 and target JDK8
END_COMMIT_OVERRIDE

Error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project api-common: Fatal error compiling: invalid flag: --release -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

@lqiu96 lqiu96 requested review from a team and blakeli0 December 5, 2022 16:41
@suztomo

suztomo commented Dec 5, 2022

Copy link
Copy Markdown
Member

Can you ensure the user of this library can use it with Java 8?

suztomo
suztomo suggested changes Dec 5, 2022
View reviewed changes

@suztomo suztomo left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure compatibility for Java 8 users.

I contributed to java-spanner in similar manner https://github.com/googleapis/java-spanner/pull/1870/files.

JAVA8_HOME and JAVA11_HOME are available.

@suztomo

suztomo commented Dec 5, 2022

Copy link
Copy Markdown
Member

Fatal error compiling: invalid flag: --release

This parameter should not be used when you're running in JDK 8.

@lqiu96

lqiu96 commented Dec 5, 2022

Copy link
Copy Markdown
Member Author

Closing in favor of: #420

@lqiu96 lqiu96 closed this Dec 5, 2022
@lqiu96 lqiu96 reopened this Dec 5, 2022
@lqiu96 lqiu96 mentioned this pull request Dec 5, 2022
Closed
@lqiu96

lqiu96 commented Dec 5, 2022

Copy link
Copy Markdown
Member Author

We've decided to build with JDK11.

@lqiu96

lqiu96 commented Dec 5, 2022

Copy link
Copy Markdown
Member Author

@suztomo @blakeli0 Can you re-review this whenever you get a chance?

@suztomo

suztomo commented Dec 6, 2022

Copy link
Copy Markdown
Member

Can you test it in Java 8?

suztomo
suztomo approved these changes Dec 6, 2022
View reviewed changes

@suztomo suztomo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build Java 11 and running Java 8 test is already implemented

@lqiu96 lqiu96 merged commit 1862611 into main Dec 6, 2022
@lqiu96 lqiu96 deleted the main-use_java11 branch December 6, 2022 15:55
@lqiu96 lqiu96 added the release-please:force-run To run release-please label Dec 6, 2022
@release-please release-please Bot removed the release-please:force-run To run release-please label Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@blakeli0 blakeli0 Awaiting requested review from blakeli0

1 more reviewer

@suztomo suztomo suztomo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lqiu96 @suztomo