Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

Fixing version - making SNAPSHOT#32

Merged
garrettjonesgoogle merged 5 commits into
googleapis:masterfrom
garrettjonesgoogle:master
Nov 2, 2017
Merged

Fixing version - making SNAPSHOT#32
garrettjonesgoogle merged 5 commits into
googleapis:masterfrom
garrettjonesgoogle:master

Conversation

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

codecov-io commented Nov 2, 2017

Copy link
Copy Markdown

Codecov Report

Merging #32 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage     59.23%   59.23%           
  Complexity      138      138           
=========================================
  Files            15       15           
  Lines           601      601           
  Branches         91       91           
=========================================
  Hits            356      356           
  Misses          223      223           
  Partials         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 084bbe0...e56cd59. Read the comment docs.

@vam-google vam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garrettjonesgoogle

Copy link
Copy Markdown
Contributor Author

I fixed openjdk7 in Travis - we can apply this same fix to gax-java. PTAL.

@vam-google vam-google left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread .travis.yml Outdated
addons:
# https://github.com/travis-ci/travis-ci/issues/5227#issuecomment-165131913
hosts:
- fakehostnametoworkaroundtravisbug

This comment was marked as spam.

@garrettjonesgoogle garrettjonesgoogle merged commit a563935 into googleapis:master Nov 2, 2017
miraleung pushed a commit that referenced this pull request Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants