Conversation
googlebot
added
the
cla: yes
|
Thank you, @marwan-at-work! Can you please figure out why Travis CI thinks that |
|
@gmlewis seems that gofmt 1.11 has different rules from 1.10 and 1.9? We can put a space between the longer field to make both gofmt's happy, but I wonder if this is worth investigating before "just making it work" |
|
Thanks for fixing the Travis CI build, @marwan-at-work! Since we recently removed support for Go 1.7 and bumped the version number, and this PR now removes support for Go 1.8, can you please make this semantic version be v18.0.0 and we will tag it as such when we merge the PR? Also, can you please make the necessary change to |
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
After the requested v18.0.0 change and the change to README.md, this LGTM.
Awaiting second LGTM from @juliaferraioli before merging.
|
To answer your question about investigating differences in |
juliaferraioli
left a comment
juliaferraioli
left a comment
There was a problem hiding this comment.
Thanks @marwan-at-work! LGTM.
|
Thank you, @juliaferraioli! |
|
Thank you both :) |
|
I think |
|
Perhaps the README should contain instructions for pre-go1.11 users as well? |
|
@tmc yes that was a typo on my end, will push a fix. Thanks for the callout! |
|
As for pre go 1.11, the latest Go 1.9 and 1.10 should work fine with the new import path. However they wouldn't work with Go 1.8 or before that. So before 1.8, they can just use v17 or below. But maybe the readme should just say the package requires Go1.9.X or above? |
|
...and it does:
|
| - "1.9.x" | ||
| - "1.8.x" | ||
| - master | ||
| - tip |
There was a problem hiding this comment.
@marwan-at-work Can you please help me understand why "master" was replaced with "tip"? I tried reading the PR description and commit messages, and didn't find a rationale there.
The latest Travis CI documentation says:
or use
masterto get the latest version from source
That's why this change is unexpected for me and I'd like to understand it better.
There was a problem hiding this comment.
@dmitshur im not sure but it failed for me and switched to tip because we use tip at athens. I don't know the difference, but maybe we can open a pr and check?
There was a problem hiding this comment.
I can do a quick experiment.
Update: https://travis-ci.org/google/go-github/builds/426983699 LGTM.
| ```go | ||
| import "github.com/google/go-github/github" | ||
| import "github.com/google/go-github/github/v18" | ||
| ``` |
There was a problem hiding this comment.
Given that modules were released very recently and are still experimental/optional, perhaps it's a good idea to expand this to have two sections: one for traditional GOPATH workspaces (with import "github.com/google/go-github/github"), and another section for module-aware environments (with import "github.com/google/go-github/v18/github").
There was a problem hiding this comment.
@dmitshur yes, and probably should include go get part too?
6 participants
This PR is generated by a tool I wrote that helps migrate Go packages that are tagged +2 to Semantic Import Versioning.
Note that this change should be backwards compatible and can still be imported without the
/vXsuffix when Go Modules is off.