go-github: add support for issue locking / unlocking#280
Closed
gmlewis wants to merge 1 commit intogoogle:masterfrom
Closed
go-github: add support for issue locking / unlocking#280gmlewis wants to merge 1 commit intogoogle:masterfrom
gmlewis wants to merge 1 commit intogoogle:masterfrom
Conversation
| defer teardown() | ||
|
|
||
| mux.HandleFunc("/repos/o/r/issues/1/lock", func(w http.ResponseWriter, r *http.Request) { | ||
| testMethod(t, r, "PUT") |
Collaborator
There was a problem hiding this comment.
to better simulate the actual GitHub API, go ahead and have this return a 204 status:
w.WriteHeader(http.StatusNoContent)same with Unlock test below
Fixes google#279. Change-Id: I55ffdadfe5970d664ac94048e8bc2b8f5d935903
gmlewis
force-pushed
the
issue-lock-unlock
branch
from
4c28d89 to
7e6666e
Compare
Collaborator
|
two minor things:
I've gone ahead and made these minor changes and merged as ac77c93. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #279.
Change-Id: I55ffdadfe5970d664ac94048e8bc2b8f5d935903