#621 - add the logging of requestId (port to 2.35.*)#1033
Merged
1 commit merged intogooddata:2.35-portfrom Jun 21, 2021
Merged
Conversation
|
Build succeeded (check pipeline). |
daniel-rusnak
force-pushed
the
621-gh-issue-port-2.35
branch
from
fbca21d to
26ab992
Compare
|
Build succeeded (check pipeline). |
Contributor
Author
|
The @peter-plochan comments from #1032 (review) fixed also here. |
daniel-rusnak
force-pushed
the
621-gh-issue-port-2.35
branch
from
26ab992 to
0616dbe
Compare
|
Build succeeded (check pipeline). |
Contributor
Author
|
The @jimirocks comments from #1032 fixed also here. |
Added 'RequestIdInterceptor' on the apache http client to generate 'requestId' for the client requests. It wasn't added to Spring 'RestTemplate' because the Sardine client doesn't use it. Added 'ResponseMissingRequestIdInterceptor' on the apache http client to add missing 'X-GDC-REQUEST' header in responses coming from WebDav server. Added the 'requestId' information to exceptions to easier tracking the problem.
daniel-rusnak
force-pushed
the
621-gh-issue-port-2.35
branch
from
0616dbe to
9705937
Compare
|
Build succeeded (check pipeline). |
ghost
removed
the
ghost
merged commit
|
Build succeeded (gate pipeline).
|
Contributor
|
Separate issue #1035 created for this port to version 2.x.x |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'RequestIdInterceptor' on the apache http client to generate 'requestId' for the client requests. It wasn't added to Spring 'RestTemplate' because the Sardine client doesn't use it.
Added 'ResponseMissingRequestIdInterceptor' on the apache http client to add missing 'X-GDC-REQUEST' header in responses coming from WebDav server.
Added the 'requestId' information to exceptions to easier tracking the problem.