Add tracing middleware and helper function #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipello
reviewed
Dec 9, 2024
Comment on lines
+19
to
+21
| if len(traceHeaders) == 0 { | ||
| traceHeaders = defaultTraceHeaders | ||
| } |
There was a problem hiding this comment.
I would not put any defaults here but rather export the defaultTraceHeaders so from caller perspective it is clearer what is being done.
Pipello
reviewed
Dec 9, 2024
Pipello
left a comment
Pipello
left a comment
There was a problem hiding this comment.
Could you add a comments for the documentation?
It would also be nice to add some unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get tracing across services one has to propagate tracing headers downstream.
This PR adds a middleware copies tracing headers into request context and provides a function to add those headers to any requests you are creating to other services without having to pass around the entire request - context is enough.