Merge pull request sns-sdks#87 from MerleLiuKun/fix_param

MerleLiuKun · web-flow · commit 0100acf669c6 · 2021-01-01T19:46:18.000-08:00
fix(params): &#128027; fix when check string fields may lost some fields
diff --git a/pyfacebook/utils/param_validation.py b/pyfacebook/utils/param_validation.py
@@ -29,8 +29,9 @@ def enf_comma_separated(
         Api needed string
     """
     try:
+        # if value point with string, not check.
         if isinstance(value, str):
-            value = value.split(",")
+            value = [value]
         elif isinstance(value, (list, tuple)):
             pass
         elif isinstance(value, set):
diff --git a/tests/utils/test_param_validation.py b/tests/utils/test_param_validation.py
@@ -7,8 +7,8 @@
 class ParamValidationTest(unittest.TestCase):
     def testEnfCommaSeparated(self):
         self.assertEqual(enf_comma_separated("fields", "f1"), "f1")
-        self.assertEqual(enf_comma_separated("fields", "f1,f1,f2"), "f1,f2")
         self.assertEqual(enf_comma_separated("fields", ["f1", "f2"]), "f1,f2")
+        self.assertEqual(enf_comma_separated("fields", ["f1", "f2", "f2"]), "f1,f2")
         self.assertEqual(enf_comma_separated("fields", ("f1", "f2")), "f1,f2")
         self.assertTrue(enf_comma_separated("fields", {"f1", "f2"}))
 
