go for pytest.raises and test that the functions run

sroet · Byron · commit cd2d53844ae5 · 2021-09-18T09:26:28.000+08:00
diff --git a/test/test_remote.py b/test/test_remote.py
@@ -661,7 +661,7 @@ def test_timeout_funcs(self, repo):
         for function in ["pull", "fetch"]: #"can't get push to reliably timeout
             f = getattr(repo.remotes.origin, function)
             assert f is not None  # Make sure these functions exist
-
-            with self.assertRaisesRegex(GitCommandError,
-                                        "kill_after_timeout=0.01 s"):
+            _ = f() # Make sure the function runs
+            with pytest.raises(GitCommandError,
+                               match="kill_after_timeout=0.01 s"):
                 f(kill_after_timeout=0.01)
