docs: fix on-timeout value in create-ado-agentic-workflow prompt#1297
Merged
jamesadevine merged 1 commit intoJul 2, 2026
Merged
Conversation
The valid values for `on-timeout` are `reject` and `resume`, not `reject` and `approve`. This matches the `ApprovalOnTimeout` enum in `src/compile/types.rs` which has `Reject` and `Resume` variants (serialized via `#[serde(rename_all = "kebab-case")]`), and the correct values are already documented in `docs/safe-outputs.md`. An agent following the create prompt and writing `on-timeout: approve` would produce invalid front matter that the compiler would reject. Co-authored-by: Copilot <[email protected]>
jamesadevine
deleted the
docs/fix-on-timeout-value-in-create-prompt-b1bc2da640c00669
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent Documentation Update
Findings
on-timeoutcomment lists"approve"as a valid value — the correct value is"resume"prompts/create-ado-agentic-workflow.mdApplied Fixes
# "reject" (default) or "approve"→# "reject" (default) or "resume"in therequire-approvalexample blockNotes
How verified:
src/compile/types.rsdefinesApprovalOnTimeoutwith#[serde(rename_all = "kebab-case")]and two variants:Reject→"reject"andResume→"resume". There is no"approve"variant.types.rsassertApprovalOnTimeout::Resumeround-trips asresume.docs/safe-outputs.mdcorrectly documents the values asreject (default, fail-closed) | resume(notapprove).An agent following the old create prompt and writing
on-timeout: approvewould produce front matter that the compiler rejects at parse time, since serde denies unknown variants.Created by the agent-documentation maintainer workflow.