Skip to content

Commit 6dd3c76

Browse files
author
Christopher Dancy
committed
ADDED: test 'createContainerWithLogConfig' to ensure LogConfig was properly set
1 parent 3e00a59 commit 6dd3c76

1 file changed

Lines changed: 18 additions & 0 deletions

File tree

src/test/java/com/github/dockerjava/core/command/CreateContainerCmdImplTest.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@
3838
import com.github.dockerjava.api.model.ExposedPort;
3939
import com.github.dockerjava.api.model.HostConfig;
4040
import com.github.dockerjava.api.model.Link;
41+
import com.github.dockerjava.api.model.LogConfig;
4142
import com.github.dockerjava.api.model.Ports;
4243
import com.github.dockerjava.api.model.RestartPolicy;
4344
import com.github.dockerjava.api.model.Ulimit;
@@ -534,4 +535,21 @@ public void createContainerWithLabels() throws DockerException {
534535
labels.put("com.github.dockerjava.null", "");
535536
assertThat(inspectContainerResponse.getConfig().getLabels(), is(equalTo(labels)));
536537
}
538+
539+
@Test(groups = "ignoreInCircleCi")
540+
public void createContainerWithLogConfig() throws DockerException {
541+
542+
LogConfig logConfig = new LogConfig("none", null);
543+
CreateContainerResponse container = dockerClient.createContainerCmd("busybox").
544+
withLogConfig(logConfig).exec();
545+
546+
LOG.info("Created container {}", container.toString());
547+
548+
assertThat(container.getId(), not(isEmptyString()));
549+
550+
InspectContainerResponse inspectContainerResponse = dockerClient.inspectContainerCmd(container.getId()).exec();
551+
552+
// null becomes empty string
553+
assertEquals(inspectContainerResponse.getHostConfig().getLogConfig().type, logConfig.type);
554+
}
537555
}

0 commit comments

Comments
 (0)