This repository was archived by the owner on Jul 15, 2024. It is now read-only.
refactor(tests): refactor into split tests#164
Merged
Merged
Conversation
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=========================================
Coverage 37.30% 37.30%
Complexity 14431 14431
=========================================
Files 1574 1574
Lines 182845 182845
Branches 26931 26931
=========================================
Hits 68207 68207
Misses 106719 106719
Partials 7919 7919 Continue to review full report at Codecov.
|
* Each client is now tested separately. * For clients that create resources, we now use a common pattern of maintaining a multiset of resource identifiers to clean up at the end of the test class. * For operations that create resources, we now use the functionality to wait on operations rather than sleeping. * If an operation fails, we will fail the test (or setup)
stephaniewang526
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maintaining a multiset of resource identifiers to clean up at the end of
the test class.
wait on operations rather than sleeping. This cuts the integration test time
from 20 minutes to under 10 minutes.
Turns out that we were silently hitting quota limits. Because we now check the status of the long running operations, we will actually be able to see the quota issue rather than a failing test that tries to find the resource.
Fixes #165