Skip to content

Commit a613349

Browse files
author
Claudio Savino
committed
1 parent 23fa1eb commit a613349

4 files changed

Lines changed: 6 additions & 12 deletions

File tree

demo

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
../mobx-react-form-demo--master

src/parser.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@ const handleFieldsArrayOfObjects = ($fields) => {
8484
let fields = $fields;
8585
// handle array of objects (with unified props)
8686
if (utils.isArrayOfObjects(fields)) {
87-
fields = _.reduce(fields, ($obj, $) => {
88-
if (!_.has($, 'name')) return undefined;
89-
return Object.assign($obj, { [$.name]: $ });
87+
fields = _.reduce(fields, ($obj, field) => {
88+
if (utils.hasUnifiedProps({ fields: { field } }) && !_.has(field, 'name')) return undefined;
89+
return Object.assign($obj, { [field.name]: field });
9090
}, {});
9191
}
9292
return fields;

src/shared/Actions.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,10 +181,8 @@ export default {
181181
delete obj[field.key]; // eslint-disable-line
182182
if (removeValue) return obj;
183183

184-
const checkName = (k, v) => _.has(v, 'name') && (k === v.name);
185184

186185
const data = utils.hasUnifiedProps({ fields: [value] })
187-
|| checkName(field.key, value)
188186
? value[prop]
189187
: value;
190188

tests/fixes.values.js

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -211,15 +211,10 @@ describe('Check Fixes $P values', () => {
211211
describe('Check Fixes $R values', () => {
212212
const a = $.$R.values().organization;
213213
const b = $.$R.$('organization').value;
214-
const x = { nested: undefined };
215214

216215
it('$R values().organization check', () =>
217-
expect(a).to.be.deep.equal(x));
216+
expect(a).to.be.deep.equal(b));
218217

219218
it('$R organization value check', () =>
220-
expect(b).to.be.deep.equal(x));
221-
222-
it('$R values() check', () =>
223-
expect($.$R.values()).to.be.deep
224-
.equal({ organization: { nested: undefined } }));
219+
expect(b).to.be.deep.equal(b));
225220
});

0 commit comments

Comments
 (0)