Seeing unless !thing breaks my brain
#284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
issyl0
commented
Apr 24, 2025
issyl0
commented
- If not not thing, so it's actually yes thing!
- Enable the RuboCop rule and add justification to the style guide.
- If not not thing, so it's actually yes thing! - Enable the RuboCop rule and add justification to the style guide.
There was a problem hiding this comment.
Pull Request Overview
This PR aims to enforce a clearer conditional style by enabling RuboCop’s Style/NegatedUnless rule and updating the style guide accordingly. Key changes include enabling the rule in the configuration file and adding a description with examples in the style guide.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config/default.yml | Enables RuboCop's Style/NegatedUnless rule for clearer conditionals. |
| STYLEGUIDE.md | Updates the style guide with a clear guideline and examples discouraging the use of negated unless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.