Skip to content

[instructions] Sync instruction files with release v0.79.8#39527

Merged
pelikhan merged 1 commit into
mainfrom
instructions-sync-engines-roles-v0.79.8-457cd4e338646c9e
Jun 16, 2026
Merged

[instructions] Sync instruction files with release v0.79.8#39527
pelikhan merged 1 commit into
mainfrom
instructions-sync-engines-roles-v0.79.8-457cd4e338646c9e

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Summary

Instructions-janitor pass against release v0.79.8 (latest; commit 8b02ab33). Only one commit landed since the release tag (a91954a, an executive-report chore touching no docs or .github/aw/ files), so the work focused on the standing size, duplication, and accuracy audits.

Files changed

  • .github/aw/syntax-agentic.md (499 → 499 lines; in-place edits, no line growth)

Accuracy fixes (code is source of truth)

Two concrete drifts found and corrected against pkg/workflow/ and pkg/parser/schemas/main_workflow_schema.json:

  1. engine: list incomplete. Docs listed only copilot/claude/codex/gemini/opencode. The engine catalog (pkg/workflow/engine_definition.go, engine_catalog_test.go) and the canonical docs/reference/engines.md table both ship the experimental engines crush and pi as user-selectable. Added them (marked experimental) to both the string-format line and the object-format id: comment. antigravity is in the catalog but not yet in the official engines reference table, so it was intentionally left out to match user-facing docs.
  2. ignored-roles valid values undocumented. Docs showed only the default [admin, maintain, write]. The schema enum (main_workflow_schema.json:10674) also allows triage and read. Documented the full value set.

Audits with no changes required

  • Safe-outputs accuracy: verified safe-outputs*.md against safe_outputs_config.go and the schema — defaults (max-patch-size 4096KB, max-patch-files 100, timeout 45m), body limits (20–65000 chars), and field names (state-reason, allow-workflows, max-size) all match. No drift.
  • Recently-added frontmatter fields: emoji, models (custom pricing), engine.bare confirmed documented (syntax-agentic.md / token-optimization.md).
  • default-safe-outputs ecosystem: correctly documented in syntax-tools-imports.md as a safe-outputs.allowed-domains identifier; deliberately NOT added to network.md (which scopes network:), since that would be wrong context.
  • Size audit: wc -l .github/aw/*.md — all files ≤ 500. Largest is syntax-agentic.md at 499 (at the limit; flagged below).
  • Duplication audit: reviewed creator/updater/debugger/optimize/upgrade prompts vs. workflow-constraints.md / workflow-editing.md / workflow-patterns.md. Some reinforcement of read-only security posture and recompilation rules recurs across the standalone task prompts, but it is intentional (each prompt is loaded independently) and existing cross-references are present — no consolidation made this pass to avoid degrading standalone usability.

Watch item

syntax-agentic.md sits at exactly 499 lines. Per the size mandate, the next addition of content should extract a focused sub-file rather than push it over 500. This PR added no new lines (edits are in place).

🤖 Generated with [Claude Code]((claude.com/redacted)

Generated by 🧹 Instructions Janitor · 375.6 AIC · ⌖ 8.43 AIC · ⊞ 4.6K ·

  • expires on Jun 18, 2026, 2:24 AM UTC-08:00

Align .github/aw/syntax-agentic.md frontmatter reference with the
authoritative engine catalog and schema:

- engine: add experimental `crush` and `pi` to the string/id lists
  (engine_definition.go catalog + docs/reference/engines.md list both)
- user-rate-limit.ignored-roles: document the full valid value set
  (admin/maintain/write/triage/read) per main_workflow_schema.json
  enum, not just the default

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@github-actions github-actions Bot added automation documentation Improvements or additions to documentation instructions labels Jun 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

Great work from the Instructions Janitor on keeping syntax-agentic.md accurate against the v0.79.8 release! 🧹 The accuracy fixes for the engine: list (adding crush and pi as experimental) and the full ignored-roles enum values are exactly the kind of drift corrections that keep agent instructions reliable.

One minor note:

  • No test changes included — this is expected for a docs-only patch and not a blocker, but if the project has any schema-validation or doc-lint checks for .github/aw/ instruction files, it would be worth ensuring they run against this change.

If you'd like to add automated coverage for instruction file accuracy, you can assign this prompt to your coding agent:

Investigate whether there are existing tests or CI checks that validate accuracy of `.github/aw/*.md` instruction files against the Go source of truth (e.g. `pkg/workflow/engine_definition.go` and `pkg/parser/schemas/main_workflow_schema.json`). If no such tests exist, add a lightweight test or linter step that:
1. Parses the engine enum from `engine_definition.go` and verifies all user-selectable engines are mentioned in `syntax-agentic.md`.
2. Parses the `ignored-roles` enum from `main_workflow_schema.json` and verifies all values are documented in `syntax-agentic.md`.
Place the test in the appropriate test file under `pkg/` or as a CI script under `scripts/`.

Generated by ✅ Contribution Check · 515.4 AIC · ⌖ 13.5 AIC · ⊞ 24.7K ·

@pelikhan pelikhan merged commit e306fe0 into main Jun 16, 2026
@pelikhan pelikhan deleted the instructions-sync-engines-roles-v0.79.8-457cd4e338646c9e branch June 16, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation documentation Improvements or additions to documentation instructions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant