CJS: ignore impacted JS runs when no matching test files exist#38339
Merged
Conversation
Co-authored-by: pelikhan <[email protected]>
Copilot
AI
changed the title
fix: ignore impacted JS runs when no test files match
CJS: ignore impacted JS runs when no matching test files exist
Jun 10, 2026
Copilot created this pull request from a session on behalf of
pelikhan
June 10, 2026 11:26
View session
pelikhan
approved these changes
Jun 10, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the test-impacted-js Makefile target so impacted JavaScript runs don’t fail when the changed-file filter results in no matching test files, avoiding non-actionable CI failures while keeping normal test execution behavior when matches exist.
Changes:
- Added Vitest’s
--passWithNoTestsflag to the impacted JS test invocation. - Kept the full JS test target unchanged (
make test-jsstill runs as before).
Show a summary per file
| File | Description |
|---|---|
| Makefile | Updates the impacted JS test command to tolerate “no test files found” when filtering by changed paths. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impacted JS CI currently fails when a changed source file is passed to Vitest as a filter but no
*.test.{js,cjs}file matches, causing a non-actionable red run. This PR makes that path non-failing while preserving normal test execution when matches exist.Problem surface
make test-impacted-jspipes changed JS/TS paths intonpm run test:js ....ai_credits_context.cjs), Vitest exits with code1(No test files found), failing the workflow.Change
Makefileto pass Vitest’s no-test tolerance flag.Behavioral effect