Fix Windows path separator bug silently dropping `Merge remote .github folder` step by Copilot · Pull Request #31102 · github/gh-aw

Copilot · 2026-05-08T23:50:29Z

Bug Fix

What was the bug?

On Windows, filepath.Join produces backslash-separated paths. import_bfs.go was comparing item.fullPath against the forward-slash literal "/.github/agents/", so the match always failed on Windows. This left acc.agentFile and acc.agentImportSpec empty, causing needsGithubMerge to evaluate false in the compiler and silently omitting the Merge remote .github folder step from compiled lockfiles — producing a lockfile that differs from Linux output and breaks gh-aw-lockfile-check CI for Windows contributors.

How did you fix it?

Normalize item.fullPath with filepath.ToSlash before all forward-slash substring operations, mirroring the pattern already used in isCustomAgentFile (remote_fetch.go):

// Before
isAgentFile := strings.Contains(item.fullPath, "/.github/agents/") && ...
if idx := strings.Index(item.fullPath, "/.github/"); idx >= 0 {
    acc.agentFile = item.fullPath[idx+1:]
    ...
}

// After
fullPathSlash := filepath.ToSlash(item.fullPath)
isAgentFile := strings.Contains(fullPathSlash, "/.github/agents/") && ...
if idx := strings.Index(fullPathSlash, "/.github/"); idx >= 0 {
    acc.agentFile = fullPathSlash[idx+1:]
    ...
}

The original item.fullPath is preserved only for log lines that should reflect the OS-native path.

Testing

TestAgentImportWithToolsArray in agent_import_integration_test.go is the existing regression test for this path — it was already written to catch this failure but was only run on Linux. On Windows with the fix applied, it passes and gh aw compile produces a lockfile byte-identical to Linux output.

Co-authored-by: pelikhan <[email protected]>

Use filepath.ToSlash to normalize item.fullPath before substring checks for /.github/agents/ and /.github/ to ensure cross-platform compatibility. On Windows, filepath.Join produces backslashes which caused the agent file detection to silently fail, dropping the Merge remote .github folder step. Co-authored-by: pelikhan <[email protected]>

Copilot

Pull request overview

Fixes a Windows-only path normalization bug in the import BFS logic that prevented detecting custom agent files under .github/agents, which could cause compiled outputs to silently omit agent-related behavior (notably the remote .github merge step) compared to Linux.

Changes:

Normalize item.fullPath via filepath.ToSlash before performing "/.github/..." substring checks in pkg/parser/import_bfs.go.
Regenerate multiple workflow lockfiles to propagate MCP-gateway-derived outputs (e.g., effective_tokens_rate_limit_error) and include apiProxy.maxEffectiveTokens in embedded AWF config JSON.
Adjust threat-detection error handling in lockfiles to avoid downgrading errors to warnings when the detection execution itself failed.

Show a summary per file

File	Description
pkg/parser/import_bfs.go	Normalizes import paths to forward slashes to make `.github/agents` detection work on Windows.
.github/workflows/video-analyzer.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/test-workflow.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation and AWF `maxEffectiveTokens`.
.github/workflows/test-project-url-default.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/test-dispatcher.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/smoke-opencode.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/smoke-gemini.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/smoke-crush.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/smoke-ci.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/release.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/poem-bot.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/jsweep.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/issue-triage-agent.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/hippo-embed.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/gpclean.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/firewall.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/example-permissions-warning.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/dev.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/daily-malicious-code-scan.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/copilot-token-optimizer.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/codex-github-remote-mcp-test.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/code-simplifier.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/changeset.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/brave.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`, and threat-detection guard logic.
.github/workflows/bot-detection.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/ai-moderator.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.
.github/workflows/ace-editor.lock.yml	Regenerated lockfile: adds ET rate-limit output propagation, AWF `maxEffectiveTokens`.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Files reviewed: 70/218 changed files
Comments generated: 1

@@ -345,6 +345,7 @@ jobs:
      agentic_engine_timeout: ${{ steps.detect-copilot-errors.outputs.agentic_engine_timeout || 'false' }}
      checkout_pr_success: ${{ steps.checkout-pr.outputs.checkout_pr_success || 'true' }}
      effective_tokens: ${{ steps.parse-mcp-gateway.outputs.effective_tokens }}
+      effective_tokens_rate_limit_error: ${{ steps.parse-mcp-gateway.outputs.effective_tokens_rate_limit_error || 'false' }}


pelikhan · 2026-05-09T00:10:06Z

@copilot review all comments

These lockfile updates (effective_tokens_rate_limit_error output, apiProxy.maxEffectiveTokens config, etc.) were unrelated to the Windows path separator fix and were accidentally included in a previous commit. Restore all 217 lockfiles to their base state. Co-authored-by: pelikhan <[email protected]>

Copilot · 2026-05-09T00:15:03Z

@copilot review all comments

The 217 lockfile changes were unrelated to the Windows path separator fix — they were accidentally picked up from the working tree during an earlier report_progress call. They have been reverted in the latest commit, leaving only the intended change to pkg/parser/import_bfs.go.

Initial plan

8de3c6b

Copilot AI assigned Copilot and pelikhan May 8, 2026

Copilot started work on behalf of pelikhan May 8, 2026 23:50 View session

Copilot AI linked an issue May 8, 2026 that may be closed by this pull request

Bug: gh aw compile on Windows silently drops the Merge remote .github folder step for agent imports #31097

Closed

Copilot AI and others added 2 commits May 8, 2026 23:55

Fix Windows path separator issue in import_bfs.go

9b4a4ec

Co-authored-by: pelikhan <[email protected]>

Copilot AI changed the title ~~[WIP] Fix gh aw compile issue on Windows with .lock.yml generation~~ Fix Windows path separator bug silently dropping Merge remote .github folder step May 8, 2026

Copilot finished work on behalf of pelikhan May 8, 2026 23:59

Copilot AI requested a review from pelikhan May 8, 2026 23:59

pelikhan marked this pull request as ready for review May 9, 2026 00:02

Copilot AI review requested due to automatic review settings May 9, 2026 00:02

Copilot started reviewing on behalf of pelikhan May 9, 2026 00:03 View session

Copilot AI reviewed May 9, 2026

View reviewed changes

Copilot started work on behalf of pelikhan May 9, 2026 00:10 View session

Copilot finished work on behalf of pelikhan May 9, 2026 00:15

pelikhan merged commit bb070ec into main May 9, 2026

pelikhan deleted the copilot/fix-gh-aw-compile-windows-issue branch May 9, 2026 00:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Windows path separator bug silently dropping `Merge remote .github folder` step#31102

Fix Windows path separator bug silently dropping `Merge remote .github folder` step#31102
pelikhan merged 4 commits into
mainfrom
copilot/fix-gh-aw-compile-windows-issue

Copilot AI commented May 8, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

pelikhan commented May 9, 2026

Uh oh!

Copilot AI commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bug Fix

What was the bug?

How did you fix it?

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

pelikhan commented May 9, 2026

Uh oh!

Copilot AI commented May 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 8, 2026 •

edited

Loading