Skip to content

Add poetry to caching dependencies package managers#17927

Merged
steveward merged 3 commits intogithub:mainfrom
jaagut:patch-2
May 18, 2022
Merged

Add poetry to caching dependencies package managers#17927
steveward merged 3 commits intogithub:mainfrom
jaagut:patch-2

Conversation

@jaagut
Copy link
Copy Markdown
Contributor

@jaagut jaagut commented May 17, 2022 •
edited
Loading

Why:

Closes #17926

What's being changed:

Added poetry package manager as a supported python package manager for dependency caching, as can be seen in the images below:
image
image

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link
Copy Markdown

welcome bot commented May 17, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 17, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 17, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/automating-builds-and-tests/building-and-testing-python.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
 fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
actions/using-workflows/caching-dependencies-to-speed-up-workflows.md fpt
ghec
ghes
 fpt
ghec
ghes

@jaagut
Copy link
Copy Markdown
Contributor Author

jaagut commented May 17, 2022 •
edited
Loading

I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).

Sorry, I don't get where I have to click Modified...
Although, the View deployment works and the changes rendered as expected for the non-interactive articles.
In case of the Beta interactive mode, the changes seem not to be rendered.

@jaagut
Copy link
Copy Markdown
Contributor Author

jaagut commented May 17, 2022

Not sure, if this chapter also needs to be updated...

steveward
steveward approved these changes May 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@steveward steveward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jaagut. The interactive articles have actually just been removed so you don't need to worry about having to get those updated. These changes look good so I'll get this merged. ✨

@steveward steveward enabled auto-merge May 18, 2022 19:55
@steveward steveward merged commit 9dc8de6 into github:main May 18, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 18, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@jaagut jaagut deleted the patch-2 branch May 19, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steveward steveward steveward approved these changes

Assignees

No one assigned

Labels

triage Do not begin working on this issue until triaged by the team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Actions: Caching workflow dependencies: poetry package manager is missing

2 participants

@jaagut @steveward