feat: add propagateTraceparent option #1161
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if clientOptions.TracePropagationTargets != nil { | ||
| tracePropagationTargets = clientOptions.TracePropagationTargets | ||
| } | ||
| propagateTraceparent = clientOptions.PropagateTraceparent |
There was a problem hiding this comment.
Bug: propagateTraceparent read from wrong hub at construction time
The propagateTraceparent option is read from sentry.CurrentHub() at round tripper construction time and cached in the struct. However, during RoundTrip, the hub used for getting baggage and trace data comes from sentry.GetHubFromContext(request.Context()), which may be a different hub with different client options. This causes a mismatch where the traceparent propagation decision uses stale configuration instead of the configuration from the request's associated hub.
Additional Locations (2)
There was a problem hiding this comment.
This on the other hand is incorrect. The recommended way to Init sentry is using the sentry.Init func which populate the client options on the CurrentHub and that's why we read them from there on init.
Description
This PR adds the propagateTraceparent option to the SDK, for propagating the W3C
traceparentheader to downstream SDKs.Issues