feat: Add Spotlight integration for local development debugging #1085
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1085 +/- ##
==========================================
- Coverage 86.04% 85.93% -0.12%
==========================================
Files 62 63 +1
Lines 6090 6241 +151
==========================================
+ Hits 5240 5363 +123
- Misses 635 657 +22
- Partials 215 221 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks for your PR, but we won't merge this anytime soon. We have a big refactor coming in our transport and we can look at this afterwards maybe. |
|
@cleptric Thanks for the update! I first asked about Spotlight support back in June 2024 and only heard back a year later with "no progress", so I went ahead and built this to give the community something useful and closer to what Python/JS already have (and to help offload some effort since the Sentry team is swamped). I understand holding off until the transport refactor, but is there a public roadmap or place where this is being discussed? It would really help contributors know what’s changing and avoid working on features that might get blocked. Happy to rebase once things stabilize! |
DAcodedBEAT
force-pushed
the
feature/spotlight
branch
from
493d2c2 to
7ba9727
Compare
|
I'm ok merging this now instead of waiting for our refactoring, as the surface area is indeed rather small. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
DAcodedBEAT
force-pushed
the
feature/spotlight
branch
from
7ba9727 to
ae10b0d
Compare
Sorry for missing the lint errors! I've fixed it and re-pushed (trying to keep a clean git history for y'all). Let me know if there's anything else I can do to get this merged! |
giortzisg
left a comment
giortzisg
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Left some small comments. Let's get them fixed and we can merge this.
DAcodedBEAT
force-pushed
the
feature/spotlight
branch
2 times, most recently
from
a0b6588 to
d660c5e
Compare
Add SpotlightTransport that sends events to local Spotlight server for real-time debugging during development. The integration works by wrapping the existing transport and duplicating events to Spotlight. Features: - Spotlight transport decorator supporting custom URL overrides - SENTRY_SPOTLIGHT environment variable for easy enabling - Example program demonstrating usage patterns - README documentation update
Address review comments from PR: - Move SENTRY_SPOTLIGHT env var check to NewClient - Remove noopTransport check in SendEvent - Use event.Sdk.Name/Version for User-Agent header - Use context for HTTP requests - Always drain HTTP response bodies - Use shared MockTransport from mocks.go
DAcodedBEAT
force-pushed
the
feature/spotlight
branch
from
d660c5e to
dd1af08
Compare
|
@giortzisg / @cleptric - may I please get some re-reviews on this? |
Explicitly handle error from NewDsn to prevent nil pointer panic. Sentry delivery is unaffected as it occurs before Spotlight.
Add FlushCount() and CloseCount() accessors to MockTransport with optional ResetCounts() for multi-assertion tests. Update tests to verify the underlying transport methods are properly delegated instead of silently broken.
3 participants
resolves: #846
Add SpotlightTransport that sends events to local Spotlight server for real-time debugging during development. The integration works by wrapping the existing transport and duplicating events to Spotlight.
Features: