Fix GitHub issue #125 #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #125 This adds support for passing raw attributes that bypass the automatic underscore-to-dash conversion. This is useful for libraries like Datastar that use underscores as part of their DSL syntax. Users can now pass an `attrs` parameter with a dictionary of attributes that should not be converted: html.div("content", attrs={"data_store": "value"}) # Renders: <div data_store="value">content</div> This works alongside regular attributes that continue to be converted: html.button( "Click", class_="btn", attrs={"data-on-click_increment": "$store.count++"} ) # Renders: <button class="btn" data-on-click_increment="$store.count++">Click</button> Changes: - Added extract_raw_attrs() function to extract attrs parameter - Modified format_attrs() to handle raw attributes without conversion - Added comprehensive tests for the new functionality
paveldedik
force-pushed
the
claude/fix-github-issue-125-011CUrXrnhc4JDBh1cz5Xqvp
branch
from
43192f1 to
4bb6507
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Add test case for when a raw attribute has the same key as a converted regular attribute, ensuring concatenation logic is covered.
pblkt
reviewed
Nov 7, 2025
| Mapping[str, Any]: A dictionary containing raw attributes with keys as-is. | ||
| """ | ||
| extracted_attrs = {} | ||
| if (raw_attrs := attrs.get("attrs")) and isinstance(raw_attrs, dict): |
There was a problem hiding this comment.
maybe it should warn the user that attrs is not a dict.
It might be that swallowing the attr silently is surprising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125
This adds support for passing raw attributes that bypass the automatic underscore-to-dash conversion. This is useful for libraries like Datastar that use underscores as part of their DSL syntax.
Users can now pass an
attrsparameter with a dictionary of attributes that should not be converted:This works alongside regular attributes that continue to be converted:
Changes: