Skip to content

Commit 9448828

Browse files
gregmagolanmatsko
gregmagolan
authored and
matsko
committed
refactor(bazel): remove @angular/bazel protractor rule now provided by @bazel/protractor (angular#32485)
BREAKING CHANGE: Angular bazel users using protractor_web_test_suite from @angular/bazel npm package should now switch to the @bazel/protractor npm package. This should impact very few users and the user's that are impacted have a very easy upgrade path to switch to fetching the protractor_web_test_suite rule via the @bazel/protractor npm package. PR Close angular#32485
1 parent 2124588 commit 9448828

33 files changed

Lines changed: 0 additions & 1014 deletions

‎.github/angular-robot.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@ merge:
4545
- "packages/bazel/src/api-extractor/**"
4646
- "packages/bazel/src/builders/**"
4747
- "packages/bazel/src/ng_package/**"
48-
- "packages/bazel/src/protractor/**"
4948
- "packages/bazel/src/schematics/**"
5049
- "packages/compiler-cli/ngcc/**"
5150
- "packages/docs/**"

‎modules/benchmarks/benchmark_test.bzl‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ def benchmark_test(name, server, deps, tags = []):
1111
name = name,
1212
configuration = "//:protractor-perf.conf.js",
1313
data = [
14-
"//packages/bazel/src/protractor/utils",
1514
"//packages/benchpress",
1615
],
1716
on_prepare = "//modules/benchmarks:start-server.js",

‎packages/bazel/BUILD.bazel‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ npm_package(
1111
"//packages/bazel/src/builders:package_assets",
1212
"//packages/bazel/src/ng_package:package_assets",
1313
"//packages/bazel/src/ngc-wrapped:package_assets",
14-
"//packages/bazel/src/protractor:package_assets",
1514
"//packages/bazel/src/schematics:package_assets",
1615
"//packages/bazel/third_party/github.com/bazelbuild/bazel/src/main/protobuf:package_assets",
1716
],
@@ -32,7 +31,6 @@ npm_package(
3231
"//packages/bazel/src/builders",
3332
"//packages/bazel/src/ng_package:lib",
3433
"//packages/bazel/src/ngc-wrapped:ngc_lib",
35-
"//packages/bazel/src/protractor/utils",
3634
"//packages/bazel/src/schematics/ng-add",
3735
"//packages/bazel/src/schematics/ng-new",
3836
],

‎packages/bazel/docs/BUILD.bazel‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ skylark_doc(
66
"//packages/bazel/src:ng_module.bzl",
77
"//packages/bazel/src:ng_rollup_bundle.bzl",
88
"//packages/bazel/src/ng_package:ng_package.bzl",
9-
"//packages/bazel/src/protractor:protractor_web_test.bzl",
109
],
1110
format = "html",
1211
site_root = "/bazel-builds",

‎packages/bazel/index.bzl‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,10 @@ Users should not load files under "/src"
88
"""
99

1010
load("//packages/bazel/src/ng_package:ng_package.bzl", _ng_package = "ng_package")
11-
load(
12-
"//packages/bazel/src/protractor:protractor_web_test.bzl",
13-
_protractor_web_test = "protractor_web_test",
14-
_protractor_web_test_suite = "protractor_web_test_suite",
15-
)
1611
load("//packages/bazel/src:ng_module.bzl", _ng_module = "ng_module_macro")
1712

1813
ng_module = _ng_module
1914
ng_package = _ng_package
20-
protractor_web_test = _protractor_web_test
21-
protractor_web_test_suite = _protractor_web_test_suite
2215
# DO NOT ADD PUBLIC API without including in the documentation generation
2316
# Run `yarn bazel build //packages/bazel/docs` to verify
2417

‎packages/bazel/protractor-utils.js‎

Lines changed: 0 additions & 9 deletions
This file was deleted.

‎packages/bazel/src/protractor/BUILD.bazel‎

Lines changed: 0 additions & 11 deletions
This file was deleted.

‎packages/bazel/src/protractor/protractor.conf.js‎

Lines changed: 0 additions & 177 deletions
This file was deleted.

0 commit comments

Comments
 (0)