Extra check for auto_ptr new[]

richq · richq · commit 68202d8ffbe7 · 2011-11-05T15:45:59.000+01:00
This fixes cases like this:

   auto_ptr&lt;foo&gt; bar(new foo[10]);

which previously did not work correctly.
diff --git a/lib/checkstl.cpp b/lib/checkstl.cpp
@@ -1101,6 +1101,10 @@ void CheckStl::checkAutoPointer()
                 while (tok2) {
                     if (Token::Match(tok2, "> %var%")) {
                         const Token *tok3 = tok2->next()->next();
+                        if (Token::Match(tok3, "( new %type% [")) {
+                            autoPointerArrayError(tok2->next());
+                            break;
+                        }
                         while (tok3 && tok3->str() != ";") {
                             tok3 = tok3->next();
                         }
diff --git a/test/teststl.cpp b/test/teststl.cpp
@@ -1433,6 +1433,12 @@ class TestStl : public TestFixture {
               "}\n");
         ASSERT_EQUALS("[test.cpp:3]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
 
+        check("void f() \n"
+              "{\n"
+              "    auto_ptr<T> p2( new T[5] );\n"
+              "}\n");
+        ASSERT_EQUALS("[test.cpp:3]: (error) Object pointed by an 'auto_ptr' is destroyed using operator 'delete'. You should not use 'auto_ptr' for pointers obtained with operator 'new[]'.\n", errout.str());
+
         check("void f() \n"
               "{\n"
               "    auto_ptr<T> p2;\n"
