Merged
Conversation
This was referenced Apr 9, 2019
TIHan
approved these changes
Apr 11, 2019
Contributor
TIHan
left a comment
TIHan
left a comment
There was a problem hiding this comment.
This makes me feel so much better.
Contributor
Author
I can imagine :) |
1 task
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #297
The TP config does report the ReferencedAssemblies, but IIRC there were some situations where the F# compiler was not correctly filling in this value. I've checked the code however and can't see why this would be the case.
Actually, it looks like I might have fixed this in 2016 just forgot to remove the hack fro the TPSDK dotnet/fsharp#1037, or didn't want to remove it since old tooling still needed it.
Anyway, let's see if the TPSDK passes with this in place.