Skip to content

add rst support#254

Merged
mxmehl merged 1 commit intofsfe:masterfrom
rscohn2:master
Sep 11, 2020
Merged

add rst support#254
mxmehl merged 1 commit intofsfe:masterfrom
rscohn2:master

Conversation

@rscohn2
Copy link
Contributor

@rscohn2 rscohn2 commented Sep 10, 2020

No description provided.

@mxmehl
Copy link
Member

mxmehl commented Sep 11, 2020

Thank you, looks good to me!

However, I saw that single-line comments in RST are discouraged. Do you think this is a problem in practice?

@rscohn2
Copy link
Contributor Author

rscohn2 commented Sep 11, 2020

It's not a problem. I checked the rst spec and then checked each of the possible ambiguous cases. The SPDX header does not match any of them. It would be a problem if you used one of '|', '[', or '_' after the '..'. Or if you used '::' instead of ':'.

I tried to implement the multi-line, but was getting this error:
reuse addheader: error: 'test.rst' does not support multi-line comments, please do not use --multi-line

@mxmehl
Copy link
Member

mxmehl commented Sep 11, 2020

I am not sure how to implement multiline comments in the tool, that's where @carmenbianca would have to help, but she's currently not available.

I'll merge this therefore, thanks for the contribution and explanation!

@mxmehl mxmehl merged commit 8f22fd6 into fsfe:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants