Skip to content

fix(emoji): emojies/flags were not properly themeable#2357

Merged
lubber-de merged 2 commits intofomantic:developfrom
lubber-de:emojiThemeable
Apr 30, 2022
Merged

fix(emoji): emojies/flags were not properly themeable#2357
lubber-de merged 2 commits intofomantic:developfrom
lubber-de:emojiThemeable

Conversation

@lubber-de
Copy link
Member

@lubber-de lubber-de commented Apr 29, 2022

Description

Emojis+new Flags were not properly themeable. Means, if one would have changed the theme for them inside theme.config, Those were still (also) included form the default theme, because their whole definition was done inside the overrides files.

I now moved the pure emoji list mixin into the .variables file instead of overrides and moved the generator code inside the less file. This way any modified emoji or flag list can be changed/reduced/modified in a separate theme by redeclarin the mixins as expected.

I tag this as breaking change because it could happen that somebody needs to adjust their own themes variables/overrides file for emojies.

BTW: Similar issue (still) for icons. Separate PR follows :)

Testcase

  • Change the theme for emoji to joypixels in theme.config
  • Change the theme for flags to famfamfam in theme.config
  • Build FUI

Broken

Both themes are included in semantic.css (tweemoji default and joypixels for emoji, tweemoji and famfamfam png sprite for flag)

Fixed

Only the selected theme of each element is included

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/breaking-change Any pull request which is waiting for a breaking change release labels Apr 29, 2022
@lubber-de lubber-de added this to the 2.9.0 milestone Apr 29, 2022
@lubber-de lubber-de merged commit 2e4bd56 into fomantic:develop Apr 30, 2022
@lubber-de lubber-de deleted the emojiThemeable branch April 30, 2022 22:39
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang/css Anything involving CSS tag/breaking-change Any pull request which is waiting for a breaking change release type/bug Any issue which is a bug or PR which fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants