fix(emoji): emojies/flags were not properly themeable#2357
Merged
lubber-de merged 2 commits intofomantic:developfrom Apr 30, 2022
Merged
fix(emoji): emojies/flags were not properly themeable#2357lubber-de merged 2 commits intofomantic:developfrom
lubber-de merged 2 commits intofomantic:developfrom
Conversation
exoego
approved these changes
Apr 30, 2022
mvorisek
reviewed
Sep 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Emojis+new Flags were not properly themeable. Means, if one would have changed the theme for them inside theme.config, Those were still (also) included form the default theme, because their whole definition was done inside the overrides files.
I now moved the pure emoji list mixin into the .variables file instead of overrides and moved the generator code inside the less file. This way any modified emoji or flag list can be changed/reduced/modified in a separate theme by redeclarin the mixins as expected.
I tag this as breaking change because it could happen that somebody needs to adjust their own themes variables/overrides file for emojies.
Testcase
joypixelsin theme.configfamfamfamin theme.configBroken
Both themes are included in semantic.css (tweemoji default and joypixels for emoji, tweemoji and famfamfam png sprite for flag)
Fixed
Only the selected theme of each element is included