Remove http-api tests from nightly and run tests on unstable by default#8646
Merged
Conversation
jimmygchen
added
ready-for-review
Member
Author
|
Manually triggered a workflow from my fork: |
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
Bot
added
waiting-on-author
Member
|
I guess the CI failures are just because of compiler updates |
Member
Author
|
Yep that's right. The manual workflow linked above passed. I'm not sure why it hasn't triggered on this fork yet, and I don't see anything wrong with the Might try to do a manual run after merging to see if it fixes this. |
michaelsproul
approved these changes
Jan 12, 2026
nadtech-hub
pushed a commit
to nadtech-hub/lighthouse
that referenced
this pull request
Jan 23, 2026
2 tasks
frisitano
added a commit
to eth-act/lighthouse
that referenced
this pull request
Apr 21, 2026
The http-api broadcast_validation tests panic on every pre-deneb fork
("Should always be a blinded payload response" at
beacon_node/beacon_chain/src/test_utils.rs:965) because
make_blinded_block_with_modifier demands a blinded payload response that
the mock-builder path can't produce pre-deneb. Upstream sigp/lighthouse
hit the same failure and resolved it by removing the job from the
nightly workflow (sigp#8646) on the grounds that these tests
aren't relevant to prior forks. Mirror that here so the nightly sweep
can go green while still covering beacon-chain, op-pool, and network
tests across every prior fork.
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http-apitests are failing for earlier forks, but I think we might be able to just remove them for earlier forks in the nightly tests as they're no longer relevant.https://github.com/sigp/lighthouse/actions/runs/20869883982/job/59969302898
I've also updated the workflow to run on
unstableby default, and allow for override when the workflow is manually triggered.This PR points to the
stablebranch, as GitHub actions only schedule workflows from thestablebranch.