Skip to content

Conversation

@krajek
Copy link
Contributor

@krajek krajek commented Oct 4, 2018

Closes #858.
A simple generalization of ExecutionMethod allowed enough flexibility to support both Action and Func<Task.

@dennisdoomen dennisdoomen requested a review from jnyrup October 5, 2018 05:08
@krajek krajek force-pushed the async_execution_time branch from fc20316 to 0655213 Compare October 5, 2018 19:34
@krajek
Copy link
Contributor Author

krajek commented Oct 5, 2018

I have just adjusted the implementation. Instead of generalizing the code I just added separate ExecutionTime constructor accepting Func<Task>. Some code needed to be copied but I think @jnyrup was right in his review and synchronous and asynchronous cases should be handled separately.

Ready for merge.

@krajek
Copy link
Contributor Author

krajek commented Oct 5, 2018

BTW, follow up PR will deliver ExecutionTimeOf in async mode.

@dennisdoomen dennisdoomen merged commit 7be38a2 into fluentassertions:master Oct 7, 2018
@krajek krajek deleted the async_execution_time branch October 7, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants