Skip to content

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Sep 16, 2025

By suggestion from NuGet/Home#7921 (comment)

By default, Microsoft.NET.NuGetOfflineCache.targets (imported by Microsoft.NET.Sdk.BeforeCommon.targets) will add an extra search path for nuget packages that is not controlled by the user nuget.config. It will add the sdk/NuGetFallbackFolder from your dotnet installation to the set of nuget search locations. This could potentially poison your nuget cache between repos, even if you've configured per-repo nuget caches.

https://github.com/dotnet/reproducible-builds/blob/main/docs/Reproducible-MSBuild/Techniques/DisableImplicitNuGetFallbackFolder.md

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

CONTRIBUTOR LICENSE GRANT

By submitting this contribution, the contributor hereby irrevocably grants to the project owners and maintainers a perpetual, worldwide, royalty-free, irrevocable license to use, reproduce, modify, distribute, sublicense, and create derivative works of the contribution for any purpose and under any terms, including proprietary licensing.

The contributor waives any moral rights in the contribution to the extent permitted by law and agrees not to assert any claim of authorship or control over the contribution. The contributor represents that they are the sole author of the contribution and that it is provided free of any third-party claims.

The contributor understands and agrees that the maintainers may, at their sole discretion, use, license, or redistribute the contribution as part of any work and under any terms they choose, without further permission or attribution.

  • I have read the Contributor License Grant and accept the conditions
  • I'm interested in a free license for Fluent Assertions and will share my email address through [email protected]

@github-actions
Copy link

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17770109661

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.292%

Totals Coverage Status
Change from base Build 17573844780: 0.0%
Covered Lines: 12572
Relevant Lines: 12774

💛 - Coveralls

@jnyrup jnyrup merged commit c670e93 into fluentassertions:main Sep 16, 2025
8 checks passed
@jnyrup jnyrup deleted the lockfile2 branch September 16, 2025 15:56
@jnyrup jnyrup added the building Building and Infrastructure of Fluent Assertions label Sep 16, 2025
@jnyrup jnyrup mentioned this pull request Sep 16, 2025
9 tasks
This was referenced Sep 25, 2025
This was referenced Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants