-
Notifications
You must be signed in to change notification settings - Fork 733
Optimize various string operations #3037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Pull Request Test Coverage Report for Build 13617136846Details
💛 - Coveralls |
dennisdoomen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title doesn't seem to cover the purpose of this PR, right? It's about performance optimizations and not about text cleanup.
Thanks, updated the title to clarify what's going on. |
Three little changes to move/remove some cruft when working with strings.
For the first commit I benchmarked the difference between several alternatives and the most primitive one was the fastest one.
Benchmark results
Benchmark code
The second and third commit uses better overloads of
string.Replaceandstring.SplitIMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome