Optimize various string operations#3037
Merged
Merged
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Pull Request Test Coverage Report for Build 13617136846Details
💛 - Coveralls |
dennisdoomen
approved these changes
Mar 2, 2025
dennisdoomen
left a comment
Member
There was a problem hiding this comment.
The title doesn't seem to cover the purpose of this PR, right? It's about performance optimizations and not about text cleanup.
Member
Author
Thanks, updated the title to clarify what's going on. |
This was referenced Jul 21, 2025
This was referenced Jun 25, 2026
This was referenced Jul 2, 2026
Open
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three little changes to move/remove some cruft when working with strings.
For the first commit I benchmarked the difference between several alternatives and the most primitive one was the fastest one.
Benchmark results
Benchmark code
The second and third commit uses better overloads of
string.Replaceandstring.SplitIMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome