Skip to content

Conversation

@dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Jan 4, 2025

Because of the order of initialization, changing the GlobalConfiguration.TestFramework did not have any effect. Fortunately, Qodana highlighted that we were never setting that property, and thus we were missing a test while implementing #2901.

In fact, this PR also addressed some Qodana warnings that did not surface until after merging #2901.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@dennisdoomen dennisdoomen marked this pull request as ready for review January 4, 2025 16:45
@coveralls
Copy link

coveralls commented Jan 4, 2025

Pull Request Test Coverage Report for Build 12612419587

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.402%

Totals Coverage Status
Change from base Build 12611827882: 0.002%
Covered Lines: 12286
Relevant Lines: 12470

💛 - Coveralls

@dennisdoomen dennisdoomen requested a review from jnyrup January 4, 2025 16:58
@github-actions
Copy link

github-actions bot commented Jan 4, 2025

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@dennisdoomen dennisdoomen merged commit da17a6a into fluentassertions:develop Jan 4, 2025
8 checks passed
@dennisdoomen dennisdoomen deleted the fix-qodana-issues branch January 5, 2025 08:51
This was referenced Dec 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants