-
Notifications
You must be signed in to change notification settings - Fork 733
GlobalConfiguration.TestFramework did not reconfigure the run-time test framework being used. #2918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dennisdoomen
merged 2 commits into
fluentassertions:develop
from
dennisdoomen:fix-qodana-issues
Jan 4, 2025
Merged
GlobalConfiguration.TestFramework did not reconfigure the run-time test framework being used. #2918
dennisdoomen
merged 2 commits into
fluentassertions:develop
from
dennisdoomen:fix-qodana-issues
Jan 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12612419587Details
💛 - Coveralls |
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
jnyrup
approved these changes
Jan 4, 2025
…st framework being used.
f6ce760 to
83174ee
Compare
This was referenced Jul 21, 2025
This was referenced Dec 22, 2025
This was referenced Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the order of initialization, changing the
GlobalConfiguration.TestFrameworkdid not have any effect. Fortunately, Qodana highlighted that we were never setting that property, and thus we were missing a test while implementing #2901.In fact, this PR also addressed some Qodana warnings that did not surface until after merging #2901.
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome