Skip to content

Remove support for HttpResponseMessage assertions #2909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 5 commits into from
Jan 3, 2025
Merged

Remove support for HttpResponseMessage assertions #2909

dennisdoomen merged 5 commits into from
Jan 3, 2025

Conversation

@ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Dec 30, 2024 •
edited
Loading

Closes #1811

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@ITaluone
Copy link
Contributor Author

ITaluone commented Dec 30, 2024

I don't get how to update the qodana.json (which contains a few references to Src/FluentAssertions/Primitives/HttpResponseMessageAssertions.cs). Shall I remove them manually?

@ITaluone ITaluone force-pushed the remove-http-response-assertions branch 2 times, most recently from 7c279cf to 8f0cc9e Compare December 30, 2024 10:43
jnyrup
jnyrup reviewed Dec 30, 2024
View reviewed changes
@coveralls
Copy link

coveralls commented Dec 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12594655269

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 97.397%
Totals Coverage Status
Change from base Build 12549789133: -0.004%
Covered Lines: 12313
Relevant Lines: 12500
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Dec 30, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@ITaluone ITaluone force-pushed the remove-http-response-assertions branch from 8f0cc9e to aff2f74 Compare December 30, 2024 10:50
@ITaluone ITaluone requested a review from jnyrup December 30, 2024 10:57
dennisdoomen
dennisdoomen reviewed Dec 30, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 We should also update upgradingtov7.md (and rename it to match the v7->v8 thing we did).

@ITaluone ITaluone force-pushed the remove-http-response-assertions branch 3 times, most recently from fb8c1be to c749a5f Compare January 2, 2025 15:11
@ITaluone ITaluone requested a review from dennisdoomen January 2, 2025 15:12
@ITaluone
Copy link
Contributor Author

ITaluone commented Jan 2, 2025

BTW.. the project description still mentions .NETCore 2.0, .NETCore 3.0 and NSpec3.

@ITaluone
Copy link
Contributor Author

ITaluone commented Jan 2, 2025

🔧 We should also update upgradingtov7.md (and rename it to match the v7->v8 thing we did).

I wonder, if we should do this in minimum one follow-up PR: the first containing the new upgradingtov7.md which targets master, and the other PR which targets develop with the upgradingtov8.md?

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Jan 2, 2025

BTW.. the project description still mentions .NETCore 2.0, .NETCore 3.0 and NSpec3.

+ Doesn't mention support for

  • XUnit3
  • TUnit

@dennisdoomen
Copy link
Member

dennisdoomen commented Jan 3, 2025

I wonder, if we should do this in minimum one follow-up PR: the first containing the new upgradingtov7.md which targets master, and the other PR which targets develop with the upgradingtov8.md?

Why? Nothing in upgradingtov7.md is relevant for v7.

dennisdoomen
dennisdoomen requested changes Jan 3, 2025
View reviewed changes
@ITaluone
Copy link
Contributor Author

ITaluone commented Jan 3, 2025

Why? Nothing in upgradingtov7.md is relevant for v7.

Not sure I get you? Dropping two target frameworks and one test framework seems relevant to me?

@ITaluone ITaluone force-pushed the remove-http-response-assertions branch 2 times, most recently from acc9f6f to 8430d4c Compare January 3, 2025 07:04
@ITaluone ITaluone requested a review from dennisdoomen January 3, 2025 07:04
@ITaluone ITaluone force-pushed the remove-http-response-assertions branch from 8430d4c to f7643f8 Compare January 3, 2025 08:01
@ITaluone ITaluone force-pushed the remove-http-response-assertions branch from f7643f8 to 31876f9 Compare January 3, 2025 08:04
This was referenced Dec 22, 2025
Open
Open
Open
Open
Open
Closed
Closed
Open
Open
Closed
Closed
Merged
Closed
Open
Open
Closed
Closed
Closed
Open
Open
This was referenced Dec 29, 2025
Open
Merged
Merged
Merged
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup Awaiting requested review from jnyrup

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove HttpResponse response and refer to FluentAssertions.Web instead

6 participants

@ITaluone @coveralls @IT-VBFK @dennisdoomen @mu88 @jnyrup