-
Notifications
You must be signed in to change notification settings - Fork 732
Downgrade System.Collections.Immutable to 1.5.0 #2890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To avoid testing with newer dependencies than what end users might be using
|
Why? #2872 only affected test projects. |
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Pull Request Test Coverage Report for Build 12376565255Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Because
Perhaps a conservative view, but by keeping the versions we use in our test projects low, we ensure that end users also don't need to pull in newer versions of these dependencies. |
Personally, I find that a bit too farfetched. But if you care about it that much, I'm fine too. |
This partly reverts #2872.
This is to avoid pulling in dependencies that are newer than what end users might be using.
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome