Skip to content

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Dec 17, 2024

This partly reverts #2872.

This is to avoid pulling in dependencies that are newer than what end users might be using.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

To avoid testing with newer dependencies than what end users might be using
@dennisdoomen
Copy link
Member

Why? #2872 only affected test projects.

@github-actions
Copy link

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12376565255

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.398%

Totals Coverage Status
Change from base Build 12359769115: 0.0%
Covered Lines: 12373
Relevant Lines: 12562

💛 - Coveralls

@jnyrup
Copy link
Member Author

jnyrup commented Dec 17, 2024

Why? #2872 only affected test projects.

Because System.Collections.Immutable 9.0.0 brings in these changes to dependencies.

  • Adds System.Buffers 4.5.1
  • Adds System.Memory 4.5.5
  • Adds System.Numerics.Vectors 4.5.0
  • Updates System.Runtime.CompilerServices.Unsafe 4.5.3 -> 6.0.0

Perhaps a conservative view, but by keeping the versions we use in our test projects low, we ensure that end users also don't need to pull in newer versions of these dependencies.

@dennisdoomen
Copy link
Member

Perhaps a conservative view, but by keeping the versions we use in our test projects low, we ensure that end users also don't need to pull in newer versions of these dependencies.

Personally, I find that a bit too farfetched. But if you care about it that much, I'm fine too.

@jnyrup jnyrup merged commit de6adcf into fluentassertions:develop Dec 18, 2024
8 checks passed
@jnyrup jnyrup deleted the Immutable_downgrade branch December 18, 2024 08:30
@jnyrup jnyrup added the dependencies Pull requests that update a dependency file label Dec 27, 2024
This was referenced Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants