Bump PolySharp from 1.14.1 to 1.15.0 #2884

dependabot · 2024-12-16T15:49:32Z

Bumps PolySharp from 1.14.1 to 1.15.0.

Release notes

1.15.0

This PolySharp release includes C# 13 support.

🪄 Polyfills

Add polyfills for .NET 9 attributes. by @teo-tsirpanis in Sergio0694/PolySharp#108

Add [ConstantExpected] polyfill by @Sergio0694 in Sergio0694/PolySharp#114

🔧 Other changes

Update NuGet packages to latest stable by @Sergio0694 in Sergio0694/PolySharp#111

Update GitHub Actions to latest stable by @Sergio0694 in Sergio0694/PolySharp#112

New Contributors

@teo-tsirpanis made their first contribution in Sergio0694/PolySharp#108

Commits

02753db Merge pull request #114 from Sergio0694/dev/constant-expected-attribute
cd55412 Add tests for '[ConstantExpected]' attribute
8ed69f9 Update 'README.md' files
b100d4b Add 'ConstantExpectedAttribute' type
06e5008 Merge pull request #108 from teo-tsirpanis/net9
81cedeb Fix a typo in CONTRIBUTING.md
92b7b24 Use .NET 9 SDK, update unit tests
d9e4541 Update README.md files
b71f56f Adapt the attributes to the codebase's standards.
32ac9c8 Copy .NET 9 attribute sources from dotnet/runtime.
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

github-actions · 2024-12-16T16:09:41Z

Test Results

36 files ±0 36 suites ±0 2m 27s ⏱️ -5s
6 115 tests ±0 6 115 ✅ ±0 0 💤 ±0 0 ❌ ±0
38 035 runs ±0 38 035 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit a78d464. ± Comparison against base commit 87bc87b.

This pull request removes 10 and adds 8 tests. Note that renamed tests count towards both.

FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
Object name: 'GetPositionExceptionMessage'.)

FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)

♻️ This comment has been updated with latest results.

coveralls · 2024-12-16T16:10:37Z

Pull Request Test Coverage Report for Build 12376681718

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 97.398%

Totals
Change from base Build 12376617590:	0.0%
Covered Lines:	12373
Relevant Lines:	12562

💛 - Coveralls

dennisdoomen · 2024-12-16T16:48:51Z

@dependabot rebase

dennisdoomen · 2024-12-16T19:22:49Z

@dependabot rebase

jnyrup · 2024-12-16T21:09:12Z

Interesting, the canceled Qodana run threw a Dictionary exception

dennisdoomen · 2024-12-17T06:13:23Z

Yeah, I wonder now if this is a Qodana issue or a Polysharp issue. I'll try with the previous version of Qodana first.

dennisdoomen · 2024-12-17T06:51:13Z

I've just tried running a PR with the previous version of Qodana and I see the same behavior. I'm going to report an issue.

Sergio0694/PolySharp#116

jnyrup · 2024-12-17T08:18:51Z

Looking at the changes in PolySharp, I think the problem is in in Qodana.
To test with an older version of Qodana, wouldn't we need to merge the revert the Qodana upgrade and then rebase this PR?

I also notice that it varies which polyfilled type from PolySharp is mentioned in the stack exceptions and that none of them changed in 1.15.0

Message = “An item with the same key has already been added. Key: PolySharp.SourceGenerators\PolySharp.SourceGenerators.PolyfillsGenerator\System.Diagnostics.CodeAnalysis.UnscopedRefAttribute.g.cs”

https://github.com/fluentassertions/fluentassertions/actions/runs/12359824708/job/34493370009#step:3:140

Message = “An item with the same key has already been added. Key: PolySharp.SourceGenerators\PolySharp.SourceGenerators.PolyfillsGenerator\System.Diagnostics.CodeAnalysis.SetsRequiredMembersAttribute.g.cs”

https://github.com/fluentassertions/fluentassertions/actions/runs/12357487327/job/34485851957#step:3:145

dennisdoomen · 2024-12-17T08:31:45Z

To test with an older version of Qodana, wouldn't we need to merge the revert the Qodana upgrade and then rebase this PR?

Good point.

dennisdoomen · 2024-12-17T15:11:36Z

The recommendation from JetBrains is to switch back to an earlier version of the Qodana plug-in until they've analyzed the problem.

dennisdoomen · 2024-12-17T15:54:39Z

@dependabot rebase

Bumps [PolySharp](https://github.com/Sergio0694/PolySharp) from 1.14.1 to 1.15.0. - [Release notes](https://github.com/Sergio0694/PolySharp/releases) - [Commits](Sergio0694/PolySharp@1.14.1...1.15.0) --- updated-dependencies: - dependency-name: PolySharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

github-actions · 2024-12-17T16:10:54Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file labels Dec 16, 2024

dependabot bot force-pushed the dependabot/nuget/PolySharp-1.15.0 branch from 4a81f11 to b04920e Compare December 16, 2024 16:58

dependabot bot force-pushed the dependabot/nuget/PolySharp-1.15.0 branch from b04920e to dcab75c Compare December 16, 2024 19:26

dennisdoomen mentioned this pull request Dec 17, 2024

Dictionary exception when using PolySharp 1.15 with JetBrains Qodana Sergio0694/PolySharp#116

Closed

dennisdoomen mentioned this pull request Dec 17, 2024

Rollback Qodana version to solve a conflict with PolySharp #2889

Merged

dependabot bot force-pushed the dependabot/nuget/PolySharp-1.15.0 branch from dcab75c to a78d464 Compare December 17, 2024 15:57

dennisdoomen merged commit 6ac14f2 into develop Dec 17, 2024
13 checks passed

dennisdoomen deleted the dependabot/nuget/PolySharp-1.15.0 branch December 17, 2024 16:52

Bump PolySharp from 1.14.1 to 1.15.0 #2884

Bump PolySharp from 1.14.1 to 1.15.0 #2884

Uh oh!

Conversation

dependabot bot commented on behalf of github Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1.15.0

🪄 Polyfills

🔧 Other changes

New Contributors

Uh oh!

github-actions bot commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

coveralls commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 12376681718

Details

💛 - Coveralls

Uh oh!

dennisdoomen commented Dec 16, 2024

Uh oh!

dennisdoomen commented Dec 16, 2024

Uh oh!

jnyrup commented Dec 16, 2024

Uh oh!

dennisdoomen commented Dec 17, 2024

Uh oh!

dennisdoomen commented Dec 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jnyrup commented Dec 17, 2024

Uh oh!

dennisdoomen commented Dec 17, 2024

Uh oh!

dennisdoomen commented Dec 17, 2024

Uh oh!

dennisdoomen commented Dec 17, 2024

Uh oh!

github-actions bot commented Dec 17, 2024

Qodana for .NET

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dependabot bot commented on behalf of github Dec 16, 2024 •

edited

Loading

github-actions bot commented Dec 16, 2024 •

edited

Loading

coveralls commented Dec 16, 2024 •

edited

Loading

dennisdoomen commented Dec 17, 2024 •

edited

Loading